Hi Ofer, Thank you very much for helping cleaning up the properties files. However, it will take time to apply it to Mifos and I am in the middle of first I18n story. I will do it after I finish the first story. I went randomly through the remove list and most of them are good candidates to remove. However, I found a couple that are not (Fees.error.feename, Office.error.hasActiveChildern) so I think when I do this I need to be careful and check again before I remove. But thank you for doing this and I will apply them to Mifos when I have the time.
kim --- Ofer Matan <[EMAIL PROTECTED]> wrote: > Kim, > > > > Sam suggested that you commit the changes at your > convenience. Let me know > if you have questions. > > > > -ofer > > > > ------------------------------------------------- > > I've run a script to find properties that are not > being referenced - a > report is attached with the dead property counts for > each *.properties file > > In the src folder. > > > > The script created a *.properties.new file which > should replace the original > after review by a developer. > > > > All suspect properties are below the following > comment: > > > > ############################################## > > ### These properties are probably not being used by > mifos. Please check and > remove > > ############################################## > > > > The ones that are above the line are not necessarily > being used - it just > means the grep found a hit - for example in > LoanUIResources > > There are a group of resources that are likely not > used (and If they are, > they should be renamed - too generic) - however the > word "fees" was found in > the source. > > > > +#-------------custom table tag > > + > > +Installment=Installment > > +DueDate=Due Date > > +Principal=Principal > > +Interest=Interest > > +Fees=Fees > > +Total=Total > > +Date=Date > > +Field=Field > > +OldValue=Old Value > > +NewValue=New Value > > +User=User > > +Description=Description > > > > > > There is at least one case where there is a property > below the line that > should not be removed: > > In > src/org/mifos/config/resources/versionInfo.properties > we have: > > > > [EMAIL PROTECTED]@ > > > > Which is used by the Build to insert the revision > number. I am not aware of > any other properties that are not referenced > directly by the code, but are > nonetheless used, but it should be verified by > developers more familiar than > I. > > > > The script was run against revision 12207. > > > > The ruby script and supporting bash script are also > included. > > > > > > > > > > > > > BulkEntryUIResources:8 dead properties found > AccountStatusUIResources:4 dead properties found > loanImages:0 dead properties found > LoanUIResources:130 dead properties found > savingsImages:0 dead properties found > SavingsUIResources:11 dead properties found > accountsImages:0 dead properties found > accountsUIResources:214 dead properties found > RolesAndPermission:5 dead properties found > SurveysUIResources:33 dead properties found > FeesUIResources:56 dead properties found > adminUIResources:11 dead properties found > Meeting:12 dead properties found > PPIUIResources:6 dead properties found > HolidayUIResources:91 dead properties found > ProductDefinitionResources:88 dead properties found > OfficeUIResources:35 dead properties found > Office:69 dead properties found > officeImages:0 dead properties found > FundUIResources:4 dead properties found > ReportsCategoryUIResources:5 dead properties found > ReportsUIResources:7 dead properties found > centerImages:0 dead properties found > CenterUIResources:51 dead properties found > GroupUIResources:73 dead properties found > groupImages:0 dead properties found > customerImages:0 dead properties found > CustomerUIResources:17 dead properties found > CustomerSearchUIResources:6 dead properties found > clientImages:0 dead properties found > ClientUIResources:77 dead properties found > personnelImages:0 dead properties found > PersonnelUIResources:8 dead properties found > ConfigurationUIResources:9 dead properties found > LoginUIResources:2 dead properties found > AcceptedPaymentTypeUIResources:0 dead properties > found > CheckListUIResources:16 dead properties found > enumerations:8 dead properties found > applicationConfiguration.default:0 dead properties > found > versionInfo:1 dead properties found > Resources:76 dead properties found > FieldUIResources:0 dead properties found > security:0 dead properties found > MenuResources:21 dead properties found > ColumnMappingBundle:54 dead properties found > LoggerStatements:4 dead properties found > UIResources:5 dead properties found > ExceptionResources:0 dead properties found > ImageResources:1 dead properties found > ApplicationResources:0 dead properties found > > > Index: > src/org/mifos/application/accounts/loan/util/resources/LoanUIResources.properties.new > =================================================================== > --- > src/org/mifos/application/accounts/loan/util/resources/LoanUIResources.properties.new > (revision 0) > +++ > src/org/mifos/application/accounts/loan/util/resources/LoanUIResources.properties.new > (revision 0) > @@ -0,0 +1,474 @@ > +#-------------------------------------------- > +loan.acc_info= account information > +loan.review/edit_ins=Review installments > +loan.review&submit=Review & submit > +loan.asterisk=Fields marked with an asterisk are > required. > +loan.colon=: > +# > Buttons---------------------------------------------- > +loan.search=Search > +loan.submit=Submit > +loan.continue=Continue > +loan.cancel=Cancel > +loan.Enter=Enter > +loan.preview=Preview > +loan.saveForLater=Save for later > +loan.submitForApproval=Submit for approval > +loan.approved=Approved > +loan.reviewtransaction=Review Transaction > +loan.returnToAccountDetails=Return to account > details > +loan.editTrxn=Edit transaction > +#Loan Account creation ---------------------- > +loan.complete_field=Complete the fields below. Then > click Preview. Click Cancel to return to Clients & > Accounts without submitting information. > +loan.redo_loan_note=Note: You are redoing a loan > account. > +loan.select_loan_inst= instance. Then click > Continue. Click Cancel to return to Clients & > Accounts without submitting information. > +loan.acc_owner=Account Owner > +loan.instance_name=Loan instance name > +loan.instancename= instance name > +loan.product_summary= Product Summary > +loan.loan_acc_details= Account Details > +loan.description=Description > +loan.interest_type= Rate Type > +loan.interest_disb= deducted at disbursement > +loan.freq_of_inst=Frequency of Installments > +loan.principle_due=Principal due on last > installment > +loan.grace_period_type=Grace Period Type > +loan.interest_rate= rate > +loan.int_rate= Rate > +loan.yes=Yes > +loan.no=No > +loan.allowed_amount=(Allowed Amount: > +loan.allowed_interest1=(Allowed > +loan.allowed_interest2= Rate Amount > +loan.no_of_inst=No. of installments > +loan.allowed_no_of_inst=(Allowed Number of > Installments: > +loan.proposed_date=Disbursal date > +loan.repayment_date=Repayment day > +loan.is_redo_loan=Loan has been redone > +loan.grace_period=Grace period for repayments > +loan.inst=Installments > +loan.source_fund=Source of fund > +loan.business_work_act=Purpose of > +loan.collateral_type=Collateral type > +loan.collateral_notes=Collateral Notes > +loan.admin_set_fees=Administrative Set Fees > +loan.apply_add_fees=Apply Additional Fees > +loan.fee_type=Fee Type > +loan.amount=Actual Amount > +loan.amountpaid=Amount Paid > +loan.amountdue=Amount Due > +loan.week(s)=Week(s) > +loan.month(s)=Month(s) > +loan.periodicity=Periodicity > +loan.periodicityTypeRate=Recur every > +loan.periodicityTypeFlat=one time > +loan.checkToRemove=Check to Remove > +#Loan Account > Installments-------------------------------------- > +loan.review&edit=Review installments > +loan.review_payment_schedule=Review the payment > schedule below. Click Preview to continue. Click > Cancel to return to Clients & Accounts without > submitting information. > +loan.amount_due=Amount due > +loan.payments=Payments > +loan.due_date=Due date > +loan.principal=Principal > +loan.interest=Interest > +loan.fees=Fees > +loan.total=Total > +loan.current_installment=Current installment > + > + > +//for loan status > +loan.status=Status > +loan.note=Note: > +//------end for loanStatus > + > + > +#-------------------------------------------------------- > +loan.edit_info=Edit the fields below. Then click > Preview. Click Cancel to return to Loan Account > Details without submitting information. > +loan.edittrans=Review the transaction below. If > satisfied click Submit. Click Cancel to return to > account details without submitting information or to > try again with changes. > +loan.edit_loan_acc=Edit account information > +loan.select=select > +loan.Select=Select > +loan.a= a > +loan.Slash=/ > +loan.apr=APR > + > + > + > + > +loan.penalty=Penalty > +#Loan Account > Preview---------------------------------------------- > +loan.reviewaccountinformation1=Review the > information below. Click Submit if you are satisfied > or click 'Edit > +loan.reviewaccountinformation2= account > information' to make changes. Click Cancel to return > to > +loan.reviewaccountinformation3= Account Details > without submitting information. > +loan.reviewaccontinfo=Review the information below. > Click Submit if you are satisfied or click Edit to > make changes. Click Cancel to return to Clients & > Accounts without submitting information. > +loan.instance_info=Instance information > +loan.charged_applied=Charges Applied > +loan.install_paid=Installments > +loan.installments=Installment > +loan.duedate=Due Date > +loan.successful_creation=You have successfully > created a new > +loan.successful_recreation=You have successfully > recreated a new > +loan.plz_note=Please Note: > +loan.congo1_1=A new > +loan.congo1_2= account for > +loan.congo2= has been assigned account # > +loan.congo3=. You can enter an account number into > the search box to access account details. > +loan.view_loan_acc1=View > +loan.view_loan_acc2= account details now > +loan.suggested_steps=Suggested next steps > +loan.open_new_acc=Open another account for > +loan.open_new=Open a new > +loan.apply_trans=Apply transactions: > +loan.apply_payment=Apply payment > +loan.mode_of_payment=Mode of payment > +loan.apply_adjustment=Apply adjustment > +#------------------------------------------------------ > +loan.accountId=Account Number > +------------------------------------------------------- > +loan.totalAmtDue=Total amount due on > +loan.arrear=Amount in arrears > +loan.interestRules= rules > +loan.repaymentRules=Repayment rules > +loan.collateralDetails=Collateral details > +loan.additionalInfo=Additional information > +loan.trxn=Transactions > +loan.apply_charges=Apply charges > +loan.edit_acc_status=Edit account status > +loan.next_inst=Next installment > +loan.view_inst_details=View installment details > +loan.acc_summary=Account summary > +loan.original_loan=Original > +loan.amt_paid=Amount paid > +loan.loan_balance= balance > +loan.recentActivity=Recent activity > +loan.view_acc_activity=View all account activity > +loan.date=Disbursal Date > +loan.desc=Description > +loan.amt=Amount > +loan.more_details=More account and transaction > details > +loan.view_schd=View repayment schedule > +loan.view_transc_history=View transaction history > +loan.view_change_log=View change log > +loan.change_log=Change Log > +loan.view_status_history=View status history > +loan.acc_details=Account details > +loan.edit_acc_info=Edit account information > +loan.recurring_acc_fees=Recurring account fees > +loan.remove=Remove > +loan.mon=(Monthly) > +loan.performance_history=Performance history > +loan.of_payments=# of payments: > === message truncated ===> ------------------------------------------------------------------------- > SF.Net email is sponsored by: The Future of Linux > Business White Paper > from Novell. From the desktop to the data center, > Linux is going > mainstream. Let it simplify your IT future. > http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4 ____________________________________________________________________________________ Be a better pen pal. Text or chat with friends inside Yahoo! Mail. See how. http://overview.mail.yahoo.com/ ------------------------------------------------------------------------- SF.Net email is sponsored by: The Future of Linux Business White Paper from Novell. From the desktop to the data center, Linux is going mainstream. Let it simplify your IT future. http://altfarm.mediaplex.com/ad/ck/8857-50307-18918-4
