This is really great, thanks Pramod. On Jan 25, 2008 3:14 AM, Van Mittal-Henkle <[EMAIL PROTECTED]> wrote: > > > Pramod, > > Thanks for the patch. It looks good and has been committed as revision > 12272. Please not the the reporterrors.properties file has been moved to > the org/mifos/config/localizedResources folder. > > Cheers, > --Van > > ________________________________ > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Pramod > Biligiri > Sent: Thursday, January 24, 2008 8:58 AM > To: Developer > Cc: Nandini Yadalam > Subject: [Mifos-developer] Fw: build failing > > > > > Hi, > I have attached a patch below (in the forwarded email) which should fix the > issue of failing testcases > in CollectionSheetReportServiceTest.java > > This patch was originally mailed to Keith, so it addresses a couple of other > small issues that he had raised in an > email. Please apply it against revision 12266. > > Pramod Biligiri, > ThoughtWorks > > ----- Forwarded by Pramod Biligiri/India/ThoughtWorks on 01/24/2008 10:26 PM > ----- > > Pramod Biligiri/India/ThoughtWorks > > 01/24/2008 09:04 PM > > To "Keith Pierce" <[EMAIL PROTECTED]> > > cc "Beth Mazur" <[EMAIL PROTECTED]>, "Nandini Yadalam" > <[EMAIL PROTECTED]>, "Van Mittal-Henkle" > <[EMAIL PROTECTED]>, Amiruddin > Nagri/India/[EMAIL PROTECTED] > > Subject Re: Fwd: FW: [Mifos-developer] build failingLink > > > > > Hi Keith, > I have fixed the issue with the attached patch. I think I found the problem. > > The CollectionSheetReportServiceTest had a few test cases which were > depending on the order > of elements in the return value of the methods > CollSheetCustBO.getCollectionSheetLoanDetails and > CollSheetCustBO.getCollSheetSavingsDetails. However the return value was a > HashSet. The > fix for this was to remove the order dependency. > > I was not able to reproduce the failure on either Windows or Linux (Java > 1.5, Ubuntu 7.10). So I suggest > please confirm this patch on your Linux setup. > > About the missing references to the file "reporterrors.properties", it was > linked as a resource in > applicationContext.xml. We have overwritten our changes when upgrading to > revision 12248. > I have added it back in this patch. In tonight's call let's discuss what is > the best place to move it to. > > (This patch has been tested against revision 12266. It contains the older > PrdOfferingBO change, report > formatting changes also. As usual, ignore 1 leading path segment). > > > > Pramod Biligiri, > ThoughtWorks > > "Keith Pierce" <[EMAIL PROTECTED]> wrote on 01/24/2008 02:11:56 AM: > > > Pramod and Nandini, > > > > See the memo below and the attached unit test results. Several tests > > are failing with EasyMock failures when testing parts of the > > CollectionSheetReportsService code. Please have a look at it, and > > we'll discuss at Thursday's call. > > > > Keith > > > ---------- Forwarded message ---------- > > From: Van Mittal-Henkle <[EMAIL PROTECTED] > > > Date: Jan 23, 2008 12:48 PM > > Subject: FW: [Mifos-developer] build failing > > To: Keith Pierce <[EMAIL PROTECTED]> > > > > > > Keith, > > > > It appears that some Linux builds (Ofer & Dion) are having issues with > > easyMock related code from Thoughtworks. Can you please bring up the > > issue with them and have them look over the build output attchment to > > see if they can determine why some builds are failing? > > > > Thanks, > > --Van > > > > Ofer Matan (Contractor) wrote: > > > I just did svn up and I am getting test failures. The report is > > > attached. > > > > > > > > > run_test: > > > [echo] Using database: test > > > [junit] Running org.mifos.application.ApplicationTestSuite > > > [junit] Unexpected method call getAccount(1): > > > [junit] getAccount(2): expected: 1, actual: 0) > > > [junit] Expectation failure on verify: > > > [junit] getAccount(2): expected: 1, actual: 0) > > > [junit] Expectation failure on verify: > > > [junit] getAccount(4): expected: 1, actual: 0) > > > [junit] Tests run: 2610, Failures: 0, Errors: 3, Time elapsed: > > > 445.052 sec [junit] Test > > > org.mifos.application.ApplicationTestSuite FAILED > > > [attachment "TEST-org.mifos.application.ApplicationTestSuite.xml.gz" > > deleted by Pramod Biligiri/India/ThoughtWorks] [attachment "ATT336341. > > txt" deleted by Pramod Biligiri/India/ThoughtWorks] > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ >
------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
