Selim,
The second patch doesn't fix the issue #1447. I tried to test this fix but the
problem persist.
You need to make sure it was working well before sending patch -- simulate
enough test cases for the next time.
Emily , Aliya, Van, Adam,
I explain the problem and how to proceed to get the expected result (The loan
products in the dropdown box should be listed in increasing alphabetical order):
To obtain the result of query listed (thing which expected in all UI using this
taglib), we have to modify the collection classes type where it gets the
information.
That means changing the Map type to SortedMap in the class MifosSelectTag.java
(and managing dependencies, test classes,...).
I summarize; there is a common problematic, (given I'm puzzled when we noticed
it at this stage of development).. Anyone can verify it in any other use case
(for example :Edit user information / see list of Role..).
I think it's a critical task to include in V1.1 and perhaps we need to estimate
it during the next planning poker session.
Any comment/feedback?
- Nazir
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Nazir LAJDEL
Envoyé : mardi 5 février 2008 18:36
À : Developer
Cc : [EMAIL PROTECTED]
Objet : RE: [Mifos-developer] Patchs for issue #1446 and issue #1447
Thank you Selim for your patch. Good tests!!
-- I Just added a condition in the page to hidden labels loans and savings when
there is no results for mixed product.--
I have checked that in under revision 12285.
- Nazir
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Selim Lachiheb
Envoyé : mardi 5 février 2008 17:47
À : [EMAIL PROTECTED]; Developer
Objet : Re: [Mifos-developer] Patchs for issue #1446 and issue #1447
Hi Nazir , thanks again for your help !
I included the missed method in a new generated patch .
Please find the updated patch for issue #1446
https://mifos.dev.java.net/issues/show_bug.cgi?id=1446
<https://mifos.dev.java.net/issues/show_bug.cgi?id=1446>
Referenced in mailing list discussion:
http://thread.gmane.org/gmane.comp.finance.mifos.devel/3655
Thanks
Selim
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Nazir LAJDEL
Envoyé : mardi 5 février 2008 16:38
À : Developer
Cc : [EMAIL PROTECTED]
Objet : RE: [Mifos-developer] Patchs for issue #1446 and issue #1447
Hi Selim,
Please, Try again. The problem persist! There is a missed method named save in
the class org.mifos.application.productsmix.business.ProductMixBO.
Please be sure that all modifications were included in your patch.
under eclipse - The best way when choosing how to configure the patch is to
check the option "Recurse into sub-folders" -- If enabled (by default), it
ensure all the changes are present as part of the patch modifications are
included.
- Nazir
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Selim Lachiheb
Envoyé : lundi 4 février 2008 18:15
À : Developer
Objet : Re: [Mifos-developer] Patchs for issue #1446 and issue #1447
Hi Nazir, thanks for review
Please find the updated patch for issue #1446
https://mifos.dev.java.net/issues/show_bug.cgi?id=1446
<https://mifos.dev.java.net/issues/show_bug.cgi?id=1446>
Referenced in mailing list discussion:
http://thread.gmane.org/gmane.comp.finance.mifos.devel/3655
Thanks,
Selim
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Nazir LAJDEL
Envoyé : lundi 4 février 2008 17:08
À : Developer
Cc : [EMAIL PROTECTED]
Objet : Re: [Mifos-developer] Patchs for issue #1446 and issue #1447
Thank you Selim for your patches.
I started reviewing the first one (#1446). Overall this patch looks good,
However there's a feedback;
There is a need to write tests for method getPrdOfferingMix() in class
PrdOfferingPersistenceTest and getPrdOfferingMix in class
ProductMixBusinessServiceTest, to ensure their coverage.
Looking forward to an updated patch.
Thanks,
- Nazir
De : [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] De la part de Selim Lachiheb
Envoyé : jeudi 31 janvier 2008 15:53
À : [email protected]
Objet : [Mifos-developer] Patchs for issue #1446 and issue #1447
Hi Nazir ,
Please find the 2 patchs for review related to :
issue #1446 (https://mifos.dev.java.net/issues/show_bug.cgi?id=1446
<https://mifos.dev.java.net/issues/show_bug.cgi?id=1446> )
issue #1447 (https://mifos.dev.java.net/issues/show_bug.cgi?id=1447
<https://mifos.dev.java.net/issues/show_bug.cgi?id=1447> )
Please let me know if more information is required. Suggestions are welcome.
With Regards,
Selim
_____________________________________________________________________
Selim LACHIHEB
Software Developer
OXIA
OXIA is ISO 9001 V2000 certified company - AFAQ QUAL/2005/25140
11, Rue Claude Bernard
1002 Tunis Belvédère
Tunisia
Tel.: +216 71 28 27 00
Fax: +216 71 28 27 05
[EMAIL PROTECTED] <mailto:[EMAIL PROTECTED]>
www.oxiasoft.com <BLOCKED::http://www.oxiasoft.com/>
--~--~---------~--~----~------------~-------~--~----~
Vous avez reçu ce message, car vous êtes abonné au groupe Groupe
"OXIA_ENDA_MGMT" de Google Groupes.
Pour transmettre des messages à ce groupe, envoyez un e-mail à
l'adresse [EMAIL PROTECTED]
Pour résilier votre abonnement à ce groupe, envoyez un e-mail à
l'adresse [EMAIL PROTECTED]
Pour afficher d'autres options, visitez ce groupe à l'adresse
http://groups.google.com/group/oxia_enda_mgmt?hl=fr
-~----------~----~----~----~------~----~------~--~---
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
