[
http://mifosforge.jira.com/browse/MIFOS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=58962#action_58962
]
Stanley Kwok edited comment on MIFOS-1790 at 7/16/10 3:44 PM:
--------------------------------------------------------------
In BirtReportsUploadAction, the "edit" method is mapped to this security
constant: SecurityConstants.UPLOAD_REPORT_TEMPLATE rather than
SecurityConstants.EDIT_REPORT_INFORMATION. This is why changing "Can edit
report information" has no effect. As a possible workaround, one can uncheck
"Can upload report template", the system will prevent someone from editing
report template information. Note: this will prevent someone from uploading a
new report template.
I have a fix for this bug, but BirtReportsUploadActionStrutsTest is half broken
(it is actually being annotated with @Ignore). I have made some changes to the
unit test so that it will run, but stuck on getting "testUpgradePathNotRuined"
to pass the test. It fails because the constructor used is incompatible with
the current database version. The constructor is called like so:
activity = new AddActivity(DatabaseVersionPersistence.APPLICATION_VERSION,
(short) newActivityId, SecurityConstants.ORGANIZATION_MANAGEMENT,
DatabaseVersionPersistence.ENGLISH_LOCALE, "no name");
The constructor will throw an exception if the first parameter is >
LOOKUP_VALUE_CHANGE_VERSION (174). Since
DatabaseVersionPersistence.APPLICATION_VERSION is 216, an exception is thrown.
I think passing a value less than LOOKUP_VALUE_CHANGE_VERSION will get the test
to pass without changing the purpose of the test. Thoughts?
was (Author: skwoka):
In BirtReportsUploadAction, the "edit" method is mapped to this security
constant: SecurityConstants.UPLOAD_REPORT_TEMPLATE rather than
SecurityConstants.EDIT_REPORT_INFORMATION. This is why changing "Can edit
report information" has no effect. As a possible workaround, one can uncheck
"Can upload report template", the system will prevent someone from editing
report template information. Note: this will prevent someone from uploading a
new report template.
I have a fix for this bug, but BirtReportsUploadActionStrutsTest is half broken
(it is actually being annotated with @Ignore). I have made some changes to the
unit test so that it will run, but stuck on getting "testUpgradePathNotRuined"
to pass the test. It fails because the constructor used is incompatible with
the current database version. The constructor is called like so:
activity = new AddActivity(DatabaseVersionPersistence.APPLICATION_VERSION,
(short) newActivityId, SecurityConstants.ORGANIZATION_MANAGEMENT,
DatabaseVersionPersistence.ENGLISH_LOCALE, "no name");
The constructor will throw an exception if the first parameter is >
LOOKUP_VALUE_CHANGE_VERSION (176). Since
DatabaseVersionPersistence.APPLICATION_VERSION is 216, an exception is thrown.
I think passing a value less than LOOKUP_VALUE_CHANGE_VERSION will get the test
to pass without changing the purpose of the test. Thoughts?
> Report permission "Can edit report information" does not block editing of
> template
> ----------------------------------------------------------------------------------
>
> Key: MIFOS-1790
> URL: http://mifosforge.jira.com/browse/MIFOS-1790
> Project: mifos
> Issue Type: Bug
> Components: Roles and Permission
> Affects Versions: Release 1.1
> Environment: Platform: All, OS: All
> Reporter: jbrewster
> Assignee: mifosdeveloperqueue
> Priority: Major
> Fix For: Unscheduled
>
>
> The mifos administrator has roles and permissions option "Can edit report
> information" with v1.1. When unchecked, the user is still able to edit Report
> template information.
> Repro steps:
> 1. Logon to mifos as admin role.
> 2. Select admin tab.
> 3. Modify roles and permissions.
> 4. Uncheck "Can edit report information".
> 5. Submit changes
> 6. attempt to edit templates.
> Actual results:
> 1.1 Templates can still edited.
> Expected results:
> User would be stopped from editing template.
> Operating System / Arch / Version Windows XP / x86 / 5.1 Java Vendor / Version
> Sun Microsystems Inc. / 1.5.0_14 Database Vendor / Version MySQL /
> 5.0.51a-community-nt Database Driver / Version MySQL-AB JDBC Driver /
> mysql-connector-java-5.1.5 (
> Revision: ${svn.Revision} )
> Application Server Apache Tomcat/6.0.16 Mifos Database Version 190 Subversion
> Revision Number 12763
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
This SF.net email is sponsored by Sprint
What will you do first with EVO, the first 4G phone?
Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
