[
http://mifosforge.jira.com/browse/MIFOS-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60089#action_60089
]
Jakub Sławiński edited comment on MIFOS-3436 at 9/17/10 5:22 AM:
-----------------------------------------------------------------
Result of review:
{noformat}
In
org.mifos.platform.questionnaire.ui.controller.QuestionGroupController.getAllQuestionGroups(ModelMap
model, HttpServletRequest request)
Will you use a private method groupByEventSource so that the method would look
like
public String getAllQuestionGroups(ModelMap model, HttpServletRequest
request) {
List <QuestionGroupDetail> questionGroups =
questionnaireServiceFacade.getAllQuestionGroups();
model.addAttribute("questionGroups",
groupByEventSource(questionGroups));
return "viewQuestionGroups";
}
Avoid abbrevations to be consistent with other usages in same file
Use QuestionGroupDetail questionGroup : questionGroups instead of
QuestionGroupDetail qg : questionGroups
In
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/viewQuestionGroups.ftl
use
[#assign eventSources = questionGroups?keys] instead of [#assign keys =
questionGroups?keys]
and
[#list eventSources as eventSource] instead of [#list keys as key]
Please enhance
org.mifos.platform.questionnaire.ui.controller.QuestionGroupControllerTest.shouldGetAllQuestionGroups()
to test the splitting of question groups.
Please uncoment and fix parts of following unit tests
org.mifos.platform.questionnaire.service.QuestionnaireServiceIntegrationTest.shouldGetAllQuestionGroups()
line number 293,294
org.mifos.platform.questionnaire.ui.controller.QuestionGroupControllerTest.shouldGetAllQuestionGroups
line number 283
{noformat}
Moreover, please add at least one acceptance test.
was (Author: jslawinski):
Result of review:
In
org.mifos.platform.questionnaire.ui.controller.QuestionGroupController.getAllQuestionGroups(ModelMap
model, HttpServletRequest request)
Will you use a private method groupByEventSource so that the method would look
like
public String getAllQuestionGroups(ModelMap model, HttpServletRequest
request) {
List <QuestionGroupDetail> questionGroups =
questionnaireServiceFacade.getAllQuestionGroups();
model.addAttribute("questionGroups",
groupByEventSource(questionGroups));
return "viewQuestionGroups";
}
Avoid abbrevations to be consistent with other usages in same file
Use QuestionGroupDetail questionGroup : questionGroups instead of
QuestionGroupDetail qg : questionGroups
In
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/viewQuestionGroups.ftl
use
[#assign eventSources = questionGroups?keys] instead of [#assign keys =
questionGroups?keys]
and
[#list eventSources as eventSource] instead of [#list keys as key]
Please enhance
org.mifos.platform.questionnaire.ui.controller.QuestionGroupControllerTest.shouldGetAllQuestionGroups()
to test the splitting of question groups.
Please uncoment and fix parts of following unit tests
org.mifos.platform.questionnaire.service.QuestionnaireServiceIntegrationTest.shouldGetAllQuestionGroups()
line number 293,294
org.mifos.platform.questionnaire.ui.controller.QuestionGroupControllerTest.shouldGetAllQuestionGroups
line number 283
Moreover, please add at least one acceptance test.
> View QG list in category
> ------------------------
>
> Key: MIFOS-3436
> URL: http://mifosforge.jira.com/browse/MIFOS-3436
> Project: mifos
> Issue Type: Story
> Components: Surveys/PPI
> Affects Versions: Release E
> Reporter: Tejus Datta
> Assignee: Łukasz Domżalski
> Priority: Major
> Fix For: Release E - Unscheduled
>
> Attachments: View QG categories.jpg
>
>
> All the 'Applies To' value appear as category on the View QG list page.
> Under each category, the list of corresponding QG that are associated with
> the 'category' will need to be displayed.
> We should also display the QG status along with the QG title, for eg, display
> Inactive if the QG is marked inactive.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing.
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
