[ 
http://mifosforge.jira.com/browse/MIFOS-2659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=60644#action_60644
 ] 

Mifos Hudson Jira Plugin User commented on MIFOS-2659:
------------------------------------------------------

Integrated in !http://ci.mifos.org/hudson/images/16x16/blue.gif! [head-1.7.x 
#32|http://ci.mifos.org/hudson/job/head-1.7.x/32/]
     MIFOS-2659 : Removed the CELLING ROUNDING MODE
MIFOS-2659 : These unit tests requires custom working days to pass

Udai Gupta : 
[70a4465fd64576c3e8ef0fdddc0afb426fc14ba6|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=70a4465fd64576c3e8ef0fdddc0afb426fc14ba6]
Files : 
* common/src/main/java/org/mifos/framework/util/ConfigurationLocator.java
* 
application/src/test/java/org/mifos/framework/components/batchjobs/helpers/LoanArrearsAgingHelperIntegrationTest.java
* 
application/src/test/java/org/mifos/application/servicefacade/SavingsServiceFacadeWebTierTest.java
* 
application/src/test/java/org/mifos/accounts/savings/interest/AverageBalanceCalculationStrategyTest.java
* 
application/src/test/java/org/mifos/accounts/savings/business/SavingsBOIntegrationTest.java
* 
application/src/test/resources/org/mifos/config/resources/applicationConfiguration.custom.properties

Udai Gupta : 
[4ba4a987528ad333b6df91b15672fe5c3e2aba21|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=4ba4a987528ad333b6df91b15672fe5c3e2aba21]
Files : 
* application/src/main/java/org/mifos/config/FiscalCalendarRules.java
* 
application/src/test/java/org/mifos/accounts/savings/business/SavingsBOTest.java


> Use only default configurations for unit and integration testing 
> -----------------------------------------------------------------
>
>                 Key: MIFOS-2659
>                 URL: http://mifosforge.jira.com/browse/MIFOS-2659
>             Project: mifos
>          Issue Type: Improvement
>          Components: Build and Testing
>    Affects Versions: Release 1.5
>            Reporter: Udai Gupta
>            Assignee: mifosdeveloperqueue
>             Fix For: Gazelle Backlog
>
>
> We should get rid of 
> /application/src/test/resources/org/mifos/config/resources/applicationConfiguration.custom.properties
>  file, it is being used for tests where default configuration makes some 
> tests fail.
> The configurations which are different in custom file (from default one)
> FiscalCalendarRules.WorkingDays
> AccountingRules.CurrencyRoundingMode
> AccountingRules.InitialRoundingMode
> Additional properties that custom file has
> AccountingRules.DigitsBeforeDecimal
> AccountingRules.DigitsBeforeDecimalForInterest
> Step 0 remove the configurations that are same in custom file (to default one)
> Step 1 can be to always make sure that all unit/integration tests only look 
> application/src/test/resources/org/mifos/config/resources/applicationConfiguration.custom.properties
>  (and not ~/.mifos/applicationConfiguration.custom.properties )
> Step 2 can be to edit every test that depends on some custom configuration 
> currently set in applicationConfiguration.custom.properties with direct 
> manipulation of config, using something like 
> ConfigurationManager.setProperty()

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today.
http://p.sf.net/sfu/beautyoftheweb
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to