[
http://mifosforge.jira.com/browse/MIFOS-3934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61044#action_61044
]
Mifos Hudson Jira Plugin User commented on MIFOS-3934:
------------------------------------------------------
Integrated in !http://ci.mifos.org/hudson/images/16x16/blue.gif! [head-master
#2054|http://ci.mifos.org/hudson/job/head-master/2054/]
[FIXED MIFOS-3934]: Removed questions.short_name column.
Jakub Slawinski :
[7f7e532a223334d29339052d14af7f258e347372|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=7f7e532a223334d29339052d14af7f258e347372]
Files :
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/questionnaire/QuestionGroupTest.java
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/QuestionnaireConstants.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/SavingsDeposit_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/HolidayTest_001_result_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/service/QuestionnaireServiceFacadeTest.java
* acceptanceTests/src/test/resources/dataSets/FeeTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/loan/QuestionGroupHelper.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/mappers/QuestionnaireMapperTest.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_004_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_001_result_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/SectionDetailFormTest.java
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/addQuestion.ftl
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_011_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_004_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/application/questionnaire/migration/mappers/QuestionnaireMigrationMapperTest.java
*
acceptanceTests/src/test/resources/dataSets/LoanProcessWithDifferentCurrencyTest_002_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/CreateLoanScheduleWithMoratorium_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_004_dbunit.xml.zip
* application/src/main/java/org/mifos/application/NamedQueryConstants.java
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/builders/QuestionDtoBuilder.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanRepaymentPeriodTest_003_result_dbunit.xml.zip
* application/src/main/webapp/pages/application/surveys/jsp/question_details.jsp
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionGroupControllerTest.java
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/viewQuestionDetail.ftl
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/QuestionGroupDefinition.xsd
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_006_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/LoanAccountPerformanceHistoryTest_001_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/framework/util/helpers/PPICalculatorTest.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_009_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/PenaltyTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/questionnaire/CreateQuestionParameters.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_003_dbunit.xml.zip
* acceptanceTests/src/test/java/org/mifos/test/acceptance/group/GroupTest.java
* application/src/main/webapp/pages/application/surveys/jsp/edit_question.jsp
*
application/src/main/webapp/pages/application/surveys/jsp/viewQuestionResponses.jsp
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/validators/QuestionnaireValidatorImpl.java
* application/src/main/sql/latest-schema.sql
* application/src/main/webapp/pages/application/surveys/jsp/survey_details.jsp
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionnaireService.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/parsers/QuestionGroupDefinitionParserTest.java
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionEntity.java
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/questionDefinition.ftl
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/questionnaire/CreateQuestionGroupPage.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanRepaymentPeriodTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_007_result_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/selectQuestions.ftl
*
application/src/test/java/org/mifos/customers/client/struts/action/ClientCustActionTest.java
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/questionnaire/QuestionTest.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/validators/QuestionnaireValidatorTest.java
* application/src/main/webapp/pages/application/surveys/jsp/edit_survey.jsp
*
application/src/test/java/org/mifos/customers/group/struts/action/GroupCustActionTest.java
* application/src/main/webapp/pages/application/surveys/jsp/create_survey.jsp
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_004_result_dbunit.xml.zip
*
application/src/main/java/org/mifos/customers/ppi/helpers/XmlPPISurveyParser.java
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/ui/model/Question.java
*
application/src/main/webapp/pages/application/surveys/jsp/captureQuestionResponses.jsp
*
acceptanceTests/src/test/resources/dataSets/ClientLoanTransactionHistory_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_009_dbunit.xml.zip
*
application/src/test/java/org/mifos/accounts/savings/struts/action/SavingsAccountActionTest.java
*
acceptanceTests/src/test/resources/dataSets/LoanProcessWithDifferentCurrencyTest_001_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/persistence/SurveysPersistenceIntegrationTest.java
* application/src/main/sql/upgrade1287934290.sql
*
acceptanceTests/src/test/resources/dataSets/ClientLoanRepaymentPeriodTest_002_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/accounts/loan/struts/action/LoanAccountActionTest.java
*
acceptanceTests/src/test/resources/dataSets/PenaltyTest_002_result_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/viewQuestionGroupDetail.ftl
* application/src/main/webapp/pages/application/surveys/jsp/survey_preview.jsp
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/matchers/QuestionMatcher.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_004_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ImportTransactions_002_result_dbunit.xml.zip
* acceptanceTests/src/test/java/org/mifos/test/acceptance/client/ClientTest.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_005_dbunit.xml.zip
* application/src/main/webapp/pages/application/surveys/jsp/define_questions.jsp
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_008_result_dbunit.xml.zip
*
serviceInterfaces/src/main/java/org/mifos/platform/questionnaire/service/QuestionDetail.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_001_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_008_dbunit.xml.zip
*
application/src/main/java/org/mifos/customers/surveys/persistence/SurveysPersistence.java
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/viewQuestions.ftl
*
acceptanceTests/src/test/java/org/mifos/test/acceptance/questionnaire/CreateQuestionPage.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionTest.java
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/questionnaire.ftl
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_005_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ImportTransactions_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanDisbursalTest_001_result_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/domain/QuestionnaireServiceTest.java
*
application/src/test/java/org/mifos/customers/surveys/business/QuestionUtils.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_012_result_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionFormTest.java
*
acceptanceTests/src/test/resources/dataSets/ColSheetCustAcct_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_010_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/domain/QuestionEntity.hbm.xml
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_002_result_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/SectionQuestion.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_003_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_015_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/matchers/QuestionDetailMatcher.java
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/mappers/QuestionnaireMapperImpl.java
*
acceptanceTests/src/test/resources/dataSets/RedoLoanDisbursalTest_001_result_dbunit.xml.zip
*
application/src/main/resources/org/mifos/customers/surveys/business/Question.hbm.xml
*
application/src/test/java/org/mifos/customers/surveys/struts/tag/QuestionTagIntegrationTest.java
* application/src/main/sql/latest-data.sql
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/service/QuestionnaireServiceFacadeImpl.java
* application/src/main/webapp/pages/application/surveys/jsp/preview_question.jsp
*
acceptanceTests/src/test/resources/dataSets/UndoLoanDisbursal_002_result_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/localizedProperties/questionnaire_messages.properties
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionnaireServiceImpl.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_005_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_006_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_007_result_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/ui/model/QuestionForm.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/persistence/QuestionDaoIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_013_result_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/editQuestion.ftl
*
acceptanceTests/src/test/resources/dataSets/SavingsPerformanceHistory_001_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_002_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_014_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionGroupFormTest.java
* application/src/main/webapp/pages/application/surveys/jsp/view_questions.jsp
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_006_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/struts/action/SurveyInstanceActionStrutsTest.java
* acceptanceTests/src/test/resources/dataSets/FeeTest_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_010_result_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/persistence/SectionQuestionDaoIntegrationTest.java
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/ui/controller/QuestionController.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_003_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/ppi/business/PPIChoiceIntegrationTest.java
*
application/src/main/webapp/pages/application/surveys/jsp/survey_edit_preview.jsp
*
acceptanceTests/src/test/resources/dataSets/ColSheetLoanTest_001_result_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/questionListing.ftl
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/displayResponse.ftl
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_002_result_dbunit.xml.zip
* application/src/main/java/org/mifos/customers/surveys/business/Question.java
*
application/src/main/java/org/mifos/framework/components/audit/business/service/AuditLogServiceImpl.java
* application/src/main/sql/upgrades.txt
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_005_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_007_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/ui/controller/QuestionGroupController.java
*
application/src/test/java/org/mifos/customers/surveys/business/SurveyIntegrationTest.java
*
application/src/test/java/org/mifos/customers/ppi/helpers/XmlPPIParserTest.java
*
serviceInterfaces/src/main/java/org/mifos/platform/questionnaire/service/dtos/QuestionDto.java
*
application/src/main/java/org/mifos/customers/surveys/struts/action/QuestionsAction.java
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_005_result_dbunit.xml.zip
*
questionnaire/src/test/resources/org/mifos/platform/questionnaire/QuestionGroupDefinition.xml
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/displayResponses.ftl
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_011_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_012_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_006_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_001_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/ppi/persistence/PPIPersistenceIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_medium_005_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/persistence/QuestionDao.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/matchers/SectionQuestionDetailMatcher.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/persistence/QuestionGroupDaoIntegrationTest.java
*
application/src/test/java/org/mifos/customers/ppi/business/PPISurveyIntegrationTest.java
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/questionGroupDefinition.ftl
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_013_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/ui/model/SectionQuestionDetailForm.java
*
application/src/test/java/org/mifos/application/questionnaire/migration/QuestionnaireMigrationTest.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionControllerTest.java
*
application/src/test/java/org/mifos/customers/surveys/struts/action/QuestionsActionStrutsTest.java
*
application/src/test/java/org/mifos/customers/surveys/business/SurveyUtils.java
*
application/src/test/java/org/mifos/customers/surveys/struts/action/SurveysActionStrutsTest.java
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_003_result_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/validators/QuestionnaireValidatorForDtoTest.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_014_result_dbunit.xml.zip
*
application/src/main/java/org/mifos/application/questionnaire/migration/mappers/QuestionnaireMigrationMapperImpl.java
* application/src/main/java/org/mifos/customers/ppi/business/PPISurvey.java
*
acceptanceTests/src/test/resources/dataSets/CreateLoanScheduleWithMoratorium_002_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/center/struts/action/CenterCustActionTest.java
*
acceptanceTests/src/test/resources/dataSets/UndoLoanDisbursal_001_result_dbunit.xml.zip
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/service/QuestionnaireServiceIntegrationTest.java
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/createQuestion.ftl
*
application/src/test/java/org/mifos/application/questionnaire/struts/QuestionnaireFlowAdapterTest.java
*
serviceInterfaces/src/main/java/org/mifos/platform/questionnaire/service/SectionQuestionDetail.java
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_003_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_002_result_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/ui/model/QuestionGroupForm.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_default_003_dbunit.xml.zip
> remove questions.short_name
> ---------------------------
>
> Key: MIFOS-3934
> URL: http://mifosforge.jira.com/browse/MIFOS-3934
> Project: mifos
> Issue Type: Improvement
> Affects Versions: Release E
> Reporter: Adam Monsen
> Assignee: Jakub Sławiński
> Fix For: Release E - Iteration 10, Release E
>
> Attachments: wip.patch
>
>
> questions.question_text can be up to 1000 characters, so short_name was
> likely originally created to... display something shorter? Confirm this. If
> so, we can eliminate the column and simply crop the question text when
> necessary when it is displayed in the Web UI.
> Related discussion:
> http://thread.gmane.org/gmane.comp.finance.mifos.devel/9907
> h2. considerations
> * only use questions.question_text for question texts
> * questions up to 1000 characters will then be allowed
> ** .ftl pages (like questionDefinition.ftl) need to allow this
> ** update queries in QuestionEntity.hbm.xml
> ** update tests, as necessary
> Another bit I noticed is many references to a question "title". This was
> confusing since it doesn't match the name of any database column. I vote we
> simply remove this nomenclature, "Question" is good enough. In the code,
> simply refer to questions as "question" or "question text" as appropriate. In
> the UI, change "Question Title" to "Question" wherever it appears.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Mifos-issues mailing list
Mifos-issues@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mifos-issues
