[
http://mifosforge.jira.com/browse/MIFOS-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=61066#action_61066
]
Mifos Hudson Jira Plugin User commented on MIFOS-3897:
------------------------------------------------------
Integrated in !http://ci.mifos.org/hudson/images/16x16/blue.gif! [head-master
#2060|http://ci.mifos.org/hudson/job/head-master/2060/]
[FIXED MIFOS-3897]: Added questions.nickname column.
[FIXED MIFOS-3897]: Added missing upgrade files.
Jakub Slawinski :
[a932db63ea51e5da277d592bfd7b600d8dbf2d4d|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=a932db63ea51e5da277d592bfd7b600d8dbf2d4d]
Files :
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_006_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_011_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_004_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/business/SurveyIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_001_result_dbunit.xml.zip
*
application/src/main/java/org/mifos/customers/ppi/helpers/XmlPPISurveyParser.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_003_result_dbunit.xml.zip
* acceptanceTests/src/test/resources/dataSets/FeeTest_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanRepaymentPeriodTest_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/PenaltyTest_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_005_result_dbunit.xml.zip
*
questionnaire/src/test/resources/org/mifos/platform/questionnaire/QuestionGroupDefinition.xml
*
acceptanceTests/src/test/resources/dataSets/LoanProcessWithDifferentCurrencyTest_001_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/persistence/SurveysPersistenceIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/CreateLoanScheduleWithMoratorium_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_014_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionEntity.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_014_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/struts/action/QuestionsActionStrutsTest.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_003_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_006_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_medium_005_dbunit.xml.zip
*
serviceInterfaces/src/main/java/org/mifos/platform/questionnaire/service/dtos/QuestionDto.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/parsers/QuestionGroupDefinitionParserTest.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_004_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_006_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_004_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_013_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_005_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/PenaltyTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ColSheetLoanTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/SavingsDeposit_001_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/framework/util/helpers/PPICalculatorTest.java
*
serviceInterfaces/src/main/java/org/mifos/platform/questionnaire/service/QuestionDetail.java
* application/src/main/sql/upgrades.txt
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/RedoLoanDisbursalTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/LoanAccountPerformanceHistoryTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_007_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_008_result_dbunit.xml.zip
* application/src/main/sql/latest-schema.sql
*
acceptanceTests/src/test/resources/dataSets/UndoLoanDisbursal_002_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/ppi/persistence/PPIPersistenceIntegrationTest.java
*
questionnaire/src/test/java/org/mifos/platform/questionnaire/service/QuestionnaireServiceIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/LoanProcessWithDifferentCurrencyTest_002_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_008_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ImportTransactions_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_013_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_003_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/UndoLoanDisbursal_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_005_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_002_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ImportTransactions_002_result_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/QuestionGroupDefinition.xsd
*
acceptanceTests/src/test/resources/dataSets/CreateLoanScheduleWithMoratorium_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanRepaymentPeriodTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_012_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/SavingsPerformanceHistory_001_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/ppi/business/PPISurveyIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_010_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/struts/tag/QuestionTagIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_004_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_004_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/ppi/business/PPIChoiceIntegrationTest.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_009_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_010_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_007_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_003_result_dbunit.xml.zip
* application/src/main/sql/latest-data.sql
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_009_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_001_dbunit.xml.zip
*
questionnaire/src/main/resources/org/mifos/platform/questionnaire/domain/QuestionEntity.hbm.xml
*
acceptanceTests/src/test/resources/dataSets/ClientLoanRepaymentPeriodTest_003_result_dbunit.xml.zip
* application/src/main/java/org/mifos/customers/surveys/business/Question.java
*
application/src/test/java/org/mifos/customers/ppi/helpers/XmlPPIParserTest.java
*
application/src/main/resources/org/mifos/customers/surveys/business/Question.hbm.xml
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/mappers/QuestionnaireMapperImpl.java
*
acceptanceTests/src/test/resources/dataSets/ClientLoanTransactionHistory_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_005_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_001_result_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/business/SurveyUtils.java
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_015_dbunit.xml.zip
*
application/src/test/java/org/mifos/customers/surveys/struts/action/SurveysActionStrutsTest.java
* acceptanceTests/src/test/resources/dataSets/FeeTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_small_011_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusHistory_007_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanDisbursalTest_001_result_dbunit.xml.zip
*
application/src/main/java/org/mifos/customers/surveys/struts/action/QuestionsAction.java
*
application/src/test/java/org/mifos/customers/surveys/struts/action/SurveyInstanceActionStrutsTest.java
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_002_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/acceptance_default_003_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ClientLoanStatusChange_005_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_006_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/HolidayTest_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/DefineNewSavingsProduct_003_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/ColSheetCustAcct_001_result_dbunit.xml.zip
*
acceptanceTests/src/test/resources/dataSets/AdditionalHolidayTest_012_result_dbunit.xml.zip
*
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionnaireServiceImpl.java
Jakub Slawinski :
[eff498cfc903d357f719abeca4bdef4c6b21da09|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=eff498cfc903d357f719abeca4bdef4c6b21da09]
Files :
* application/src/main/sql/upgrade1288013750_step1.sql
* application/src/main/sql/upgrade1288013750_step2.sql
*
application/src/main/java/org/mifos/application/master/persistence/Upgrade1288013750.java
> Store an immutable reference for questions in imported question groups (such
> as PPI surveys)
> --------------------------------------------------------------------------------------------
>
> Key: MIFOS-3897
> URL: http://mifosforge.jira.com/browse/MIFOS-3897
> Project: mifos
> Issue Type: Story
> Components: Surveys/PPI
> Reporter: Kay Chau
> Assignee: Jakub Sławiński
> Priority: Major
> Fix For: Release E - Iteration 10, Release E
>
> Attachments: 0001-WIP-throwaway-code-working-on-adding-nickname.patch
>
>
> From PPI reports, we need a way to uniquely refer to questions. We want to
> avoid using the primary key. This reference should be immutable once created.
> Also, it may be used in the future for column names in denormalized data
> warehouse tables, so nicknames should follow the constraints for columns on
> [Database
> Naming
> Conventions|http://mifosforge.jira.com/wiki/display/MIFOS/Database+Naming+Conventions].
> Originally we were going to repurpose short_name, but what I'd rather do
> (given the current use of short_name and what we need) is create a new column
> called questions.nickname. The fate of short_name is outlined in MIFOS-3934.
> * add new column: questions.nickname
> * VARCHAR(64) NOT NULL
> * enforce as unique
> * service-level constraints
> ** only allow \[a-z0-9\] in this column
> * adapt test cases as necessary
> * update queries in QuestionEntity.hbm.xml
> * generate if necessary (only on creation)
> ** md5sum question text
> * immutable once created
> ** ie: no way to edit
> ** only enforce this in Java code
> * make sure questionnaire migration code works
> * XML PPI survey import must be able to specify nickname
> ** add "nickname" element to schema
> ** see attached patch
> 0001-WIP-throwaway-code-working-on-adding-nickname.patch for some ideas
> [Related
> discussion|http://thread.gmane.org/gmane.comp.finance.mifos.devel/9907/focus=9930]
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
