[
http://mifosforge.jira.com/browse/MIFOS-3859?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
jasmine sandhu updated MIFOS-3859:
----------------------------------
Attachment: 0001-parameterized-messages-for-loan-amount-validation.patch
Patch that parameterizes (almost) all messages.
Two files were modified:
1) messages.properties - now contains the parameterized messages
2) LoanProductFormBeanValidator.java - which constructs these messages for
display.
The only messages that do not show up correctly are the typeMismatch.*
messages. As an example, when I entered a string in the box instead of a
number, the displayed error message is:
Please Specify the valid Min Loan Amount for by loan cycle at row
loanAmountByLoanCycle[0].min.
but it should just be:
Please Specify the valid Min Loan Amount for by loan cycle at row 1.
But I don't believe this is working correctly in the current non-parameterized
code either. However, the error in the current code is:
Invalid data.
It does not display the message stored in typeMismatch.* ..
I did test the updates by putting strings in my messages to make sure they were
being displayed and ensuring I understood which message was displayed for which
box. I did document this within messages.properties in a shorthand notation,
feel free to remove if this documentation is confusing. I do have a copy of
this for myself and can document this on the wiki as that might be more
appropriate.
> parameterize messages used for loan amount bean validation
> ----------------------------------------------------------
>
> Key: MIFOS-3859
> URL: http://mifosforge.jira.com/browse/MIFOS-3859
> Project: mifos
> Issue Type: Improvement
> Components: Internationalization
> Reporter: Adam Monsen
> Assignee: jasmine sandhu
> Fix For: Gazelle Backlog
>
> Attachments:
> 0001-parameterized-messages-for-loan-amount-validation.patch
>
> Time Spent: 3 days
> Remaining Estimate: 1 day
>
> To ease localizability of Mifos, parameterize strings used during loan
> creation. Example:
> {noformat}
> Min.loanProduct.loanAmountByLastLoanAmount0.lower=Please Specify the valid
> Start Range Loan Amount for by last loan at row 1.
> Min.loanProduct.loanAmountByLastLoanAmount1.lower=Please Specify the valid
> Start Range Loan Amount for by last loan at row 2.
> Min.loanProduct.loanAmountByLastLoanAmount2.lower=Please Specify the valid
> Start Range Loan Amount for by last loan at row 3.
> Min.loanProduct.loanAmountByLastLoanAmount3.lower=Please Specify the valid
> Start Range Loan Amount for by last loan at row 4.
> Min.loanProduct.loanAmountByLastLoanAmount4.lower=Please Specify the valid
> Start Range Loan Amount for by last loan at row 5.
> Min.loanProduct.loanAmountByLastLoanAmount5.lower=Please Specify the valid
> Start Range Loan Amount for by last loan at row 6.
> {noformat}
> According to JSR 303, these messages are parameterizable. ie: only a single
> message should be necessary, for example:
> {noformat}
> Min.loanProduct.loanAmountByLastLoanAmount.lower=Please Specify the valid
> Start Range Loan Amount for by last loan at row {num}.
> {noformat}
> This should reduce the number of strings in
> userInterface/../messages.properties by 300 or so.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Nokia and AT&T present the 2010 Calling All Innovators-North America contest
Create new apps & games for the Nokia N8 for consumers in U.S. and Canada
$10 million total in prizes - $4M cash, 500 devices, nearly $6M in marketing
Develop with Nokia Qt SDK, Web Runtime, or Java and Publish to Ovi Store
http://p.sf.net/sfu/nokia-dev2dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
