[ 
http://mifosforge.jira.com/browse/MIFOS-4149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=62246#action_62246
 ] 

Mifos Hudson Jira Plugin User commented on MIFOS-4149:
------------------------------------------------------

Integrated in !http://ci.mifos.org/hudson/images/16x16/blue.gif! [head-master 
#2217|http://ci.mifos.org/hudson/job/head-master/2217/]
     FIXED MIFOS-4149: Added 'editable' property to questions.

Jakub Slawinski : 
[bd55668aabda16f60ad5c2db0f60bcc31a73463d|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=bd55668aabda16f60ad5c2db0f60bcc31a73463d]
Files : 
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/service/QuestionnaireServiceFacadeTest.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/mappers/QuestionnaireMapperTest.java
* 
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionState.java
* 
questionnaire/src/main/java/org/mifos/platform/questionnaire/mappers/QuestionnaireMapperImpl.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionTest.java
* 
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionnaireServiceImpl.java
* 
questionnaire/src/main/java/org/mifos/platform/questionnaire/ui/model/Question.java
* 
application/src/test/java/org/mifos/customers/client/struts/action/ClientCustActionTest.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/SectionDetailFormTest.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionGroupControllerTest.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionControllerTest.java
* 
questionnaire/src/main/resources/org/mifos/platform/questionnaire/ui/views/viewQuestionDetail.ftl
* 
serviceInterfaces/src/main/java/org/mifos/platform/questionnaire/service/QuestionDetail.java
* 
application/src/test/java/org/mifos/accounts/savings/struts/action/SavingsAccountActionTest.java
* 
application/src/test/java/org/mifos/customers/group/struts/action/GroupCustActionTest.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/domain/QuestionnaireServiceTest.java
* 
application/src/test/java/org/mifos/customers/center/struts/action/CenterCustActionTest.java
* 
questionnaire/src/main/java/org/mifos/platform/questionnaire/domain/QuestionEntity.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/validators/QuestionnaireValidatorTest.java
* 
application/src/test/java/org/mifos/accounts/loan/struts/action/LoanAccountActionTest.java
* 
questionnaire/src/test/java/org/mifos/platform/questionnaire/ui/controller/QuestionGroupFormTest.java
* 
application/src/main/java/org/mifos/customers/surveys/helpers/QuestionState.java
* 
serviceInterfaces/src/main/java/org/mifos/platform/questionnaire/service/dtos/QuestionDto.java
* 
application/src/test/java/org/mifos/application/questionnaire/struts/QuestionnaireFlowAdapterTest.java


> User is able to add additional choices to existing PPI survey question
> ----------------------------------------------------------------------
>
>                 Key: MIFOS-4149
>                 URL: http://mifosforge.jira.com/browse/MIFOS-4149
>             Project: mifos
>          Issue Type: Bug
>          Components: QuestionGroups/Surveys/PPI
>    Affects Versions: Release E
>            Reporter: jbrewster
>            Assignee: Jakub Sławiński
>             Fix For: Release E - Iteration 11, Release E
>
>
> Mifos allows user to add more question choices to existing PPI Survey 
> questions.  If user selects one of these additional options, this currently 
> breaks the BI ETL jobs.
> Repro:
> 1. Add PPI India 2008 survey
> 2. Edit question "How many pressure cookers or pressure pans does the 
> household own?" (did this on the sandbox)
> 3. Added choice "less that 7"
> 4. for client, fill in survey and choose "less that 7" for answer on that 
> question.
> 5. execute etl job - full_reload.sh.
> The script fails with:
> Error in step, asking everyone to stop because of:
> Error inserting/updating row
> Column 'ppi_score' cannot be null
> org.pentaho.di.trans.steps.insertupdate.InsertUpdate.processRow(InsertUpdate.java:294)
> org.pentaho.di.trans.step.RunThread.run(RunThread.java:40)
> java.lang.Thread.run(Thread.java:662)
> We need to consider:
> 1. how to stop users from adding choices to existing PPI questions
> 2. can we make the etl jobs more defensive against bad PPI data?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

------------------------------------------------------------------------------
Beautiful is writing same markup. Internet Explorer 9 supports
standards for HTML5, CSS3, SVG 1.1,  ECMAScript5, and DOM L2 & L3.
Spend less time writing and  rewriting code and more time creating great
experiences on the web. Be a part of the beta today
http://p.sf.net/sfu/msIE9-sfdev2dev
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to