[
http://mifosforge.jira.com/browse/MIFOS-4302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=63007#action_63007
]
Mifos Hudson Jira Plugin User commented on MIFOS-4302:
------------------------------------------------------
Integrated in !http://ci.mifos.org/hudson/images/16x16/blue.gif! [head-master
#2408|http://ci.mifos.org/hudson/job/head-master/2408/]
[MIFOS-4302]Fetching Month names dynamically instead of properties files,
refactored cashflow module
Srikanth Nutigattu :
[23e4cee04ad1891e3e3ae0356882f0f7e2009552|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head&a=commit&h=23e4cee04ad1891e3e3ae0356882f0f7e2009552]
Files :
*
application/src/main/java/org/mifos/accounts/loan/struts/action/LoanAccountAction.java
*
cashflow/src/main/resources/org/mifos/platform/cashflow/ui/views/captureCashFlow.ftl
*
application/src/test/java/org/mifos/accounts/loan/business/CashFlowDataAdaptorTest.java
* cashflow/src/main/webapp/WEB-INF/flows/captureCashFlow.xml
*
cashflow/src/main/resources/org/mifos/platform/cashflow/ui/localizedProperties/cashflow_messages_fr.properties
*
application/src/main/java/org/mifos/accounts/loan/util/InstallmentAndCashflowComparisionUtility.java
*
application/src/test/java/org/mifos/application/servicefacade/LoanServiceFacadeWebTierTest.java
*
application/src/main/java/org/mifos/accounts/loan/util/helpers/CashFlowDataDto.java
*
cashflow/src/main/java/org/mifos/platform/cashflow/ui/model/MonthlyCashFlowForm.java
* application/src/main/webapp/pages/application/loan/jsp/schedulePreview.jsp
*
cashflow/src/test/java/org/mifos/platform/cashflow/ui/model/CashFlowFormTest.java
*
application/src/test/java/org/mifos/accounts/loan/struts/action/LoanAccountActionTest.java
*
application/src/main/java/org/mifos/application/servicefacade/LoanServiceFacadeWebTier.java
*
application/src/test/java/org/mifos/accounts/loan/util/InstallmentAndCashflowComparisionUtilityTest.java
*
application/src/main/java/org/mifos/accounts/loan/business/CashFlowDataAdaptor.java
*
application/src/test/java/org/mifos/application/cashflow/struts/CashFlowAdaptorTest.java
*
cashflow/src/main/java/org/mifos/platform/cashflow/ui/model/CashFlowValidator.java
*
application/src/main/java/org/mifos/accounts/loan/struts/actionforms/LoanAccountActionForm.java
*
cashflow/src/main/resources/org/mifos/platform/cashflow/ui/localizedProperties/cashflow_messages.properties
*
cashflow/src/test/java/org/mifos/platform/cashflow/ui/controller/CashFlowControllerTest.java
*
cashflow/src/main/java/org/mifos/platform/cashflow/ui/controller/CashFlowController.java
*
application/src/main/java/org/mifos/application/cashflow/struts/CashFlowAdaptor.java
* cashflow/src/main/java/org/mifos/platform/cashflow/ui/model/CashFlowForm.java
*
cashflow/src/test/java/org/mifos/platform/cashflow/ui/model/CashFlowValidatorTest.java
* cashflow/src/main/java/org/mifos/platform/cashflow/CashFlowConstants.java
*
application/src/main/java/org/mifos/accounts/loan/struts/uihelpers/CashFlowDataHtmlBean.java
> improve cashflow strings including months & years
> -------------------------------------------------
>
> Key: MIFOS-4302
> URL: http://mifosforge.jira.com/browse/MIFOS-4302
> Project: mifos
> Issue Type: Improvement
> Components: Internationalization, Localization
> Reporter: Adam Monsen
> Assignee: Srikanth Nutigattu
> Fix For: Elsie F
>
>
> Messages like {{CashFlowForm.monthlyCashFlows.expense}} are untranslatable.
> Fix.
> More information:
> {noformat}
> -------- Original Message --------
> Subject: Re: i18n help: cashflow_messages.properties
> Date: Wed, 27 Oct 2010 23:21:07 -0500
> From: Vinod C John <[email protected]>
> To: Adam Monsen <[email protected]>
> Hi Adam,
> As you already found {0} and {1} are placeholders for month and year
> respectively. The syntax documented
> in
> http://download.oracle.com/javase/1.4.2/docs/api/java/text/MessageFormat.html,
> being special characters, do not need translation in properties file.
> But in the code, when we pass the values for month and year to these
> message parameters, we have to pass the internationalized
> value derived from Joda, like you pointed out in one of the previous
> mails and I think we are passing only English values for months from
> code as of now.
> A JIRA ticket is a good idea as anyone can pick this up. I am lost in
> some Pawdep loan calculations, will be revisiting cashflow module in a
> couple of weeks and verify this. If this is a priority, let me know, I
> will fix it right away.
> regards
> vinod
> On Wed, Oct 27, 2010 at 10:25 PM, Adam Monsen wrote:
> Hi Vinod, will you reply to my email, below?
> I'd like to add a 3rd option, one in which I'd actually prefer:
> 3. file the issue(s) in JIRA
> And I'll ask our i18n champions (Stanley Kwok and Jasmine Sandhu) to
> work on them.
> ---------- Forwarded message ----------
> From: Adam Monsen
> Date: Wed, Oct 6, 2010 at 1:10 PM
> Subject: i18n help: cashflow_messages.properties
> To: Vinod C John
> Hi Vinod,
> I think translators might get a little confused by these messages.
> What are {0} and {1}?
> CashFlowForm.monthlyCashFlows.expense=Please specify expense for {0} {1}.
> CashFlowForm.monthlyCashFlows.revenue=Please specify revenue for {0} {1}.
> CashFlowForm.monthlyCashFlows.notes=Notes should be between 1 to 300
> characters for {0} {1}.
> Will you either:
> 1. make them more clear/translatable
> 2. document these strings
> If you choose the 2nd option, a comment above each should be fine for
> now; eventually we'll want to get these in the Translatewiki.net
> format (they store them in an L10n file using the fake "_qqq" locale).
> Ah, I just took a look at 43c0a20953 ... looks like {0} and {1} are
> month and year (at least for the 1st two messages), yes?
> Anyway, just wanted to make sure our code is translatable.
> -Adam
> {noformat}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Lotusphere 2011
Register now for Lotusphere 2011 and learn how
to connect the dots, take your collaborative environment
to the next level, and enter the era of Social Business.
http://p.sf.net/sfu/lotusphere-d2d
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
