TECHDEBT: Decouple LoanOfferingBO from LoanPrdActionForm
--------------------------------------------------------

                 Key: MIFOS-4461
                 URL: http://mifosforge.jira.com/browse/MIFOS-4461
             Project: mifos
          Issue Type: Story
          Components: Technical Discussion
    Affects Versions: Elsie F - Iteration 8, Elsie F
            Reporter: keithwoodlock
            Assignee: mifosdeveloperqueue
             Fix For: Elsie F


The purpose of decoupling the application module into slightly smaler appdomain 
was to pull out all non ui/mvc related code (application and domain only) into 
a seperate module. This would allow for delivery and reuse of application 
service API through a JAR file.

However some ui/struts code had to be pushed down into appdomain to satisfy 
some coupling problems.

LoanOfferingBO requires LoanPrdActionForm and this dependency should be 
removed. As a result of this, other dependencies used by LoanPrdActionForm were 
brought down such as:

BaseActionForm
SessionUtils
TableTagConstants

The test for completing this work correctly is that the appdomain pom should 
not have any struts or http related dependencies

none of following should exist in appdomain pom.xml

        <dependency>
            <groupId>struts</groupId>
            <artifactId>struts</artifactId>
            <version>1.2.7</version>
        </dependency>
        <dependency>
            <groupId>struts</groupId>
            <artifactId>struts-el</artifactId>
            <version>1.2.7</version>
        </dependency>
        <dependency>
            <groupId>struts</groupId>
            <artifactId>struts-legacy</artifactId>
            <version>1.0</version>
        </dependency>
        <dependency>
            <groupId>strutstest</groupId>
            <artifactId>strutstest</artifactId>
            <version>2.1.4</version>
            <scope>test</scope>
        </dependency>
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>jsp-api</artifactId>
            <version>2.0</version>
            <scope>provided</scope>
        </dependency>
        <dependency>
            <groupId>javax.servlet</groupId>
            <artifactId>jstl</artifactId>
            <version>1.1.2</version>
            <scope>provided</scope>
        </dependency>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

------------------------------------------------------------------------------
Gaining the trust of online customers is vital for the success of any company
that requires sensitive data to be transmitted over the Web.   Learn how to 
best implement a security strategy that keeps consumers' information secure 
and instills the confidence they need to proceed with transactions.
http://p.sf.net/sfu/oracle-sfdevnl 
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues

Reply via email to