[
http://mifosforge.jira.com/browse/MIFOS-4653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
keithwoodlock updated MIFOS-4653:
---------------------------------
Labels: techdebt layering (was: )
Story Points: 2
Scheduled For: Product
Description:
This is part of technical debt work to isolate the domain model.
CenterBO
Pros:
#. static factory method in place and used by application code
#. Builder exists for creation of CenterBO
Cons:
#. extends customer (too much behaviour leaked into customer from other sub
classes group/client that is not relevant)
#. deprecated constructor still exists but only used by test infrastructure.
Notes:
#. Center is always created in active state
#. customer account always created with center (i presume to handle
attachment of fees etc)
#. segregated interface should be used instead of abstract method on base
class
- getPerformanceHistory is not applicable for center
- isActive method
- isActiveForFirstTime
- validate
#. validateChangeToInactive (look into proper state machine implementation
for center)
This story is about removing persistence responsibilities from CenterBO (which
is mostly done) but to finish off we should remove all use of deprecated
contructor which means:
- remove CenterBOIntegrationTest and have only unit tests around CenterBO
- remove use of deprecated Center constructor used only in integration tests
- requires tidy up of where TestObjectFactory.createCenter is used
- replace with use of Builder +
IntegrationTestObjectMother.createCenter(XXX)
was:
This is part of technical debt work to isolate the domain model.
CenterBO
Pros:
#. static factory method in place and used by application code
#. Builder exists for creation of CenterBO
Cons:
#. extends customer (too much behaviour leaked into customer from other sub
classes group/client that is not relevant)
#. deprecated constructor still exists but only used by test infrastructure.
Notes:
#. Center is always created in active state
#. customer account always created with center (i presume to handle
attachment of fees etc)
#. segregated interface should be used instead of abstract method on base
class
- getPerformanceHistory is not applicable for center
- isActive method
- isActiveForFirstTime
- validate
#. validateChangeToInactive (look into proper state machine implementation
for center)
This story is about removing persistence responsibilities from CenterBO (which
is mostly done) but to finish off we should remove all use of deprecated
contructor which means removing integration tests and
> TECHDEBT: layering: Remove persistence usage from CenterBO
> ----------------------------------------------------------
>
> Key: MIFOS-4653
> URL: http://mifosforge.jira.com/browse/MIFOS-4653
> Project: mifos
> Issue Type: Story
> Components: Centers
> Affects Versions: Release 1.6.0, Release 1.6.1, Release 2.0.0, Release
> 1.6.2, Release 2.0.1, Elsie F
> Reporter: keithwoodlock
> Fix For: Unscheduled
>
>
> This is part of technical debt work to isolate the domain model.
> CenterBO
> Pros:
> #. static factory method in place and used by application code
> #. Builder exists for creation of CenterBO
> Cons:
> #. extends customer (too much behaviour leaked into customer from other
> sub classes group/client that is not relevant)
> #. deprecated constructor still exists but only used by test
> infrastructure.
> Notes:
> #. Center is always created in active state
> #. customer account always created with center (i presume to handle
> attachment of fees etc)
> #. segregated interface should be used instead of abstract method on base
> class
> - getPerformanceHistory is not applicable for center
> - isActive method
> - isActiveForFirstTime
> - validate
> #. validateChangeToInactive (look into proper state machine implementation
> for center)
> This story is about removing persistence responsibilities from CenterBO
> (which is mostly done) but to finish off we should remove all use of
> deprecated contructor which means:
> - remove CenterBOIntegrationTest and have only unit tests around CenterBO
> - remove use of deprecated Center constructor used only in integration
> tests
> - requires tidy up of where TestObjectFactory.createCenter is used
> - replace with use of Builder +
> IntegrationTestObjectMother.createCenter(XXX)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://mifosforge.jira.com/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
