[
http://mifosforge.jira.com/browse/MIFOS-4435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=65409#comment-65409
]
Mifos Hudson Jira Plugin User commented on MIFOS-4435:
------------------------------------------------------
Integrated in !http://ci.mifos.org/hudson/images/16x16/red.png!
[acceptanceTestsImprovements
#5|http://ci.mifos.org/hudson/job/acceptanceTestsImprovements/5/]
MIFOS-4435: ModifiableParameterServletRequest updatedParameterList() uses
String instead of String[]
Michael Vorburger :
[6b1907b553e337d0b6948829d9228609c9ef6e87|http://mifos.git.sourceforge.net/git/gitweb.cgi?p=mifos/head;h=refs/heads/acceptanceTestsImprovements&a=commit&h=6b1907b553e337d0b6948829d9228609c9ef6e87]
Files :
*
application/src/main/java/org/mifos/framework/servlet/ModifiableParameterServletRequest.java
> ModifiableParameterServletRequest updatedParameterList() uses String instead
> of String[]
> ----------------------------------------------------------------------------------------
>
> Key: MIFOS-4435
> URL: http://mifosforge.jira.com/browse/MIFOS-4435
> Project: mifos
> Issue Type: Bug
> Reporter: Michael Vorburger
> Assignee: mifosdeveloperqueue
> Labels: patch
> Fix For: Mifos Backlog
>
> Attachments:
> 0001-MIFOS-4435-ModifiableParameterServletRequest-updated.patch
>
>
> While switching Mifos from on old Servlet 2.4 API JAR to Servlet 3.0 in the
> context of my MIFOS-4099 work, I came across a subtle bug (which even going
> only to 2.5 would have revealed; because in 2.5 & 3.0 the Servlet API uses
> Java Generics, in 2.4 it didn't yet) :
> The updatedParameterList() method in the ModifiableParameterServletRequest
> does:
> {code}
> Map<String, String> parameterMap = new HashMap<String,
> String>(getRequest().getParameterMap());
> {code}
> But the "The values in the parameter map are of type String array" actually
> (have always been), so it's a Map<String, String[]> really... or needs to be
> turned from a Map<String, String[]> into a Map<String, String>, if that's
> what the code wants to deal with; I've made that assumption and will apply it
> in a proposed fix.
> Please note that this bug is NOT related to the (my upcoming proposed)
> adoption of Servlet v3.0 API - I've only SEEN it in this context, but it's
> definitely wrong code today (Servlet 2.4 JAR used in build, or Servlet 2.5
> used in current Tomcat 6) already.
> I am unable to judge the severity of this bug (because I do not understand
> and don't have time to further dig into what
> ModifiableParameterServletRequest does and where it's used and for what).
> Out of precaution, I'm filing this with Priority Critical - and let others
> better judge what to do about it. The easiest is probably to just apply my
> patch.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE:
Pinpoint memory and threading errors before they happen.
Find and fix more than 250 security defects in the development cycle.
Locate bottlenecks in serial and parallel code that limit performance.
http://p.sf.net/sfu/intel-dev2devfeb
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
