[
http://mifosforge.jira.com/browse/MIFOS-4841?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=65983#comment-65983
]
keithwoodlock commented on MIFOS-4841:
--------------------------------------
Hi Ashish,
Some feedback on 'define new system user functionality using spring webflow and
freemarker'
1) I see you added in the properties into the savings_messages.properties file,
seen as the rest of the properties used in freemaker pages fro user
functioanlity are in 'messages.properties' i'll take then from savings_messages
and put into messages to keep them together.
d)We need to match existing functionality some of which is not at first obvious
but i did notice the following straightaway
- preferred language is now dropped from define system user functionality but
still exists on freemarker version
- i couldn't actually step through and create a new user, an exception
happened at the end etc
For now I won't worry to much about the exception occuring, having looked
through the implementation (which was written some time ago) I can see that it
can be done in a cleaner way so we should focus on going through each step in
the 'flow' and cleaning up both the freemarker implmentation and the spring web
flow implementation (user.xml file and associated form beans and DTOs use
To begin with 'choose office step'
need to clean up freemarker implementation.
- be consistent in how we display the wizard title and flow step title as with
other flows like savings and loan
- remove use of tables for display/centering
- ensure we don't hard code anything into forms action all forms using webflow
should look like this.
<form action="${flowExecutionUrl}" ...
- be consistent in how we display buttons/form controls on page.
To begin with i will make changes based on what i have said above. I will then
give more feedback on implementation for you.
> UI Conversion: implement define new system user using freemarker and spring
> weblfow
> -----------------------------------------------------------------------------------
>
> Key: MIFOS-4841
> URL: http://mifosforge.jira.com/browse/MIFOS-4841
> Project: mifos
> Issue Type: Story
> Affects Versions: Release G
> Reporter: keithwoodlock
> Assignee: keithwoodlock
> Fix For: Unscheduled
>
>
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Free Software Download: Index, Search & Analyze Logs and other IT data in
Real-Time with Splunk. Collect, index and harness all the fast moving IT data
generated by your applications, servers and devices whether physical, virtual
or in the cloud. Deliver compliance at lower cost and gain new business
insights. http://p.sf.net/sfu/splunk-dev2dev
_______________________________________________
Mifos-issues mailing list
Mifos-issues@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mifos-issues
