[
http://mifosforge.jira.com/browse/MIFOS-3837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=71942#comment-71942
]
Udai Gupta edited comment on MIFOS-3837 at 3/10/12 5:26 AM:
------------------------------------------------------------
Excellent work, I found it working as expected.
You have got the functionality right and I think these are just few minor (but
important) things that you have to take care of in your code.
* Don't modify jquery js/css file, use the jquery js options and css override.
** We won't be able to upgrade to new versions of Jquery.
** Your change might break some other widget of functionality where these
changes are not expected.
* Create one patch, you should create one patch per commit instead on one patch
per file.
** You can create a commit locally and then create a patch from it using "git
format-patch -M <git commit id>"
* Jquery ui JS and CSS are already included in header so we can avoid adding
those in tag (unless there is a special case)
** You should check the HTML source for Mifos page and you will find that
those js and css are included at twice or more.
** You can create a DateWidget.css and DateWidget.js to override jquery and
include that in tag instead of modifying jquery js/css
* You can also explore about FTL pages (ends with *.ftl)
was (Author: ugupta):
Excellent work, I found it working as expected.
You have got the functionality right and I think these are just few minor (but
important) things that you have to take care of in your code.
1) Don't modify jquery js/css file, use the jquery js options and css override.
- We won't be able to upgrade to new versions of Jquery.
- Your change might break some other widget of functionality where these
changes are not expected.
2) Create one patch, you should create one patch per commit instead on one
patch per file.
- You can create a commit locally and then create a patch from it using "git
format-patch -M <git commit id>"
3) Jquery ui JS and CSS are already included in header so we can avoid adding
those in tag (unless there is a special case)
- You should check the HTML source for Mifos page and you will find that
those js and css are included at twice or more.
- You can create a DateWidget.css and DateWidget.js to override jquery and
include that in tag instead of modifying jquery js/css
4) You can also explore about FTL pages (ends with *.ftl)
> Add a Date Picker Javascript Calendar for Dates Input Fields
> ------------------------------------------------------------
>
> Key: MIFOS-3837
> URL: http://mifosforge.jira.com/browse/MIFOS-3837
> Project: mifos
> Issue Type: Improvement
> Components: Navigation and UI
> Reporter: Ghislain Hachey
> Assignee: mifosdeveloperqueue
> Labels: patch
> Fix For: Unscheduled
>
> Attachments: DateTag.patch, jquery-ui.css.patch, jquery-ui.min1.patch
>
>
> All date (and date/time) input fields should have a JavaScript calendar for
> the user to pick a date (and/or date/time). This would reduce user mistakes
> regarding date inputs.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
http://mifosforge.jira.com/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
Mifos-issues mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mifos-issues
