|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________ Mifos-issues mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mifos-issues
Keith, on the commit you said Michal wasn't filtering for currency i.e. loanproducts/template returns all charges to pick from (as does loanproducts
{id}? template=true).
That's fair enough, as when creating a loan product it's not known which currency will be selected. Also, it's possible to change the currency of a loan product. I assume but haven't checked that if I tried to create a loan product having a charge with the wrong currency it would issue an error message.
The question is this. do we
1) leave it as it is - someone gets an error message if they try to save a loan product in US Dollars with a charge in Brunei Dollars
2) remove currency from charge so this problem completely goes away
3) add more UI functionality so it caters for this.
I'm happy with 1) leaving it as it is at the moment (it's very, very low impact). I'd prefer us not to code our way around too may rules at the moment and give the users and product people a chance to decide what needs to improve. We can help them by providing software that they can play around with.
There are many examples of this e.g. can a loan product have its currency changed once any loan has been associated to it? Its tempting to code it so it can't but it takes no code to leave it as it is and ask the question of people.
I think it is more important for us to do a reasonable job in putting up basic (but working) functionality and then optimising it later when others are given the chance to provide feedback.
I think it's a point/lesson I need to remind myself a bit more.
Michal, I'm looking forward to seeing the (basic) UI functionality around this and I'll put up a basic Jira task for adding charges to loans on creation.