|
||||||||
|
This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira |
||||||||
------------------------------------------------------------------------------ Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET Get 100% visibility into your production application - at no cost. Code-level diagnostics for performance bottlenecks with <2% overhead Download for free and get started troubleshooting in minutes. http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________ Mifos-issues mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mifos-issues
Kushagra,
The approach looks good, but it requires few more changes.
1. CalendarsApiResource.retrieveCalendar() method gets a calendar based on calendar id so it does not require calendarType parameter.
2. We don't want calendarType to be mandatory so if there is no value provided then default it to 'all' i.e. query for all calendar types.
3. If calendarType value is ‘all’ then return all calendarTypes.
4. In CalendarReadPlatformServiceImpl, instead of getting all calendars from data base and filter out the required calendar types, I would suggest to add filter condition in SQL query.
Modify the SQL query to include calendar_type_enum![]()
order by c.start_date ";
e.g.
final String sql = rm.schema() + " and ci.entity_id = ? and ci.entity_type_enum = ? c.calendar_type_enum in
You can pass comma separated values for c.calendar_type_enum to get only the requested calendar types.