|
Andreas,
I've noticed only today that something seems to have gone wrong with the pull request(s) re. the UI that you submitted:
It started yesterday with finding the Templates Documents tab for Client that didn't work, I did https://github.com/openMF/mifosx-community-apps/pull/406.
Today I've noticed that the Templates Documents tab for Loan also doesn't work - and here it wasn't just that minor fix (above), but the createLoanDocumentForTemplate function was completely missing in develop - although in https://github.com/weigel/mifosx-community-apps/blob/usergeneratedtemplates/IndividualLendingGeneralJavaScript/resources/IndividualLendingCode-1.8.0.RELEASE.js you DID have it. I've just submitted https://github.com/openMF/mifosx-community-apps/pull/407 about that, to be able to demo (note I've slightly refactored your JS to avoid the copy/paste functions).
BUT the Client Photo image in the sample report is still NOK (which I DID see working originally, before develop integration..) - so clearly some other code missing that didn't make it into develop, probably?
Could you please clean this up and make sure that you have submitted PR/s for all your GSoC work on the UGD UI? Either manually matching this up, or you should be able to, I think, rebase/diff from your original weigel/mifosx-community-apps/blob/usergeneratedtemplates branch to what is now actually in develop, and (re?)submit anything that was lost.
Thank you!
|
