[Mifos-issues] [JIRA] (MIFOSX-2039) Clean up Search API implementation

[Vishwas Babu A J (JIRA)]

Title: Message Title

Vishwas Babu A J created an issue   Mifos X / MIFOSX-2039 Clean up Search API implementation Issue Type: Improvement Assignee: keshav kumar mishra Created: 13/May/15 3:29 AM Priority: Minor Reporter: Vishwas Babu A J Search API seems to be repeating queries for each entity. We should remove all duplicate queries Example: final String clientExactMatchSql = " (select 'CLIENT' as entityType, c.id as entityId, c.display_name as entityName, c.external_id as entityExternalId, c.account_no as entityAccountNo " + " , c.office_id as parentId, o.name as parentName, c.mobile_no as entityMobileNo,c.status_enum as entityStatusEnum " + " from m_client c join m_office o on o.id = c.office_id where o.hierarchy like :hierarchy and (c.account_no like :search or c.display_name like :search or c.external_id like :search or c.mobile_no like :search)) "; final String clientMatchSql = " (select 'CLIENT' as entityType, c.id as entityId, c.display_name as entityName, c.external_id as entityExternalId, c.account_no as entityAccountNo " + " , c.office_id as parentId, o.name as parentName,c.mobile_no as entityMobileNo, c.status_enum as entityStatusEnum " + " from m_client c join m_office o on o.id = c.office_id where o.hierarchy like :hierarchy and (c.account_no like :partialSearch and c.account_no not like :search) or " + "(c.display_name like :partialSearch and c.display_name not like :search) or " + "(c.external_id like :partialSearch and c.external_id not like :search)or" + "(c.mobile_no like :partialSearch and c.mobile_no not like :search))"; can be written as final String clientMatchSql = " (select 'CLIENT' as entityType, c.id as entityId, c.display_name as entityName, c.external_id as entityExternalId, c.account_no as entityAccountNo " + " , c.office_id as parentId, o.name as parentName,c.mobile_no as entityMobileNo, c.status_enum as entityStatusEnum " + " from m_client c join m_office o on o.id = c.office_id where o.hierarchy like :hierarchy and (c.account_no like :search) or " + "(c.display_name like : search) or " + "(c.external_id like : search)or" + "(c.mobile_no like : search)"; The setting of "search" itself would be done based on the new parameter introduced in MIFOSX-2038 i.e if(exactSearch){ params.addValue("search", searchConditions.getSearchQuery()); }else{ params.addValue("search", "%" + searchConditions.getSearchQuery() + "%"); } Add Comment   This message was sent by Atlassian JIRA (v6.5-OD-03-002#65000-sha1:b8f65f8)

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Mifos-issues mailing list
Mifos-issues@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mifos-issues