svn commit: r739988 - in /james/mime4j/trunk/src: main/java/org/apache/james/mime4j/codec/ main/java/org/apache/james/mime4j/field/address/ main/java/org/apache/james/mime4j/util/ test/java/org/apache/james/mime4j/field/address/

[mwiederkehr]

Author: mwiederkehr
Date: Mon Feb  2 13:19:52 2009
New Revision: 739988

URL: http://svn.apache.org/viewvc?rev=739988&view=rev
Log:
eliminated possible compiler warnings

Modified:
    
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/codec/EncoderUtil.java
    
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/field/address/Builder.java
    james/mime4j/trunk/src/main/java/org/apache/james/mime4j/util/MimeUtil.java
    
james/mime4j/trunk/src/test/java/org/apache/james/mime4j/field/address/AddressTest.java

Modified: 
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/codec/EncoderUtil.java
URL: 
http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/apache/james/mime4j/codec/EncoderUtil.java?rev=739988&r1=739987&r2=739988&view=diff
==============================================================================
--- 
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/codec/EncoderUtil.java 
(original)
+++ 
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/codec/EncoderUtil.java 
Mon Feb  2 13:19:52 2009
@@ -68,7 +68,7 @@
         B,
         /** The Q encoding (similar to quoted-printable defined in RFC 2045). 
*/
         Q
-    };
+    }
 
     /**
      * Indicates the intended usage of an encoded word.

Modified: 
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/field/address/Builder.java
URL: 
http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/apache/james/mime4j/field/address/Builder.java?rev=739988&r1=739987&r2=739988&view=diff
==============================================================================
--- 
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/field/address/Builder.java
 (original)
+++ 
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/field/address/Builder.java
 Mon Feb  2 13:19:52 2009
@@ -137,8 +137,9 @@
         if (n instanceof ASTroute) {
             route = buildRoute((ASTroute) n);
             n = it.next();
-        } else if (n instanceof ASTaddr_spec)
-            ; // do nothing
+        } else if (n instanceof ASTaddr_spec) {
+            // do nothing
+        }
         else
             throw new IllegalStateException();
 

Modified: 
james/mime4j/trunk/src/main/java/org/apache/james/mime4j/util/MimeUtil.java
URL: 
http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/apache/james/mime4j/util/MimeUtil.java?rev=739988&r1=739987&r2=739988&view=diff
==============================================================================
--- james/mime4j/trunk/src/main/java/org/apache/james/mime4j/util/MimeUtil.java 
(original)
+++ james/mime4j/trunk/src/main/java/org/apache/james/mime4j/util/MimeUtil.java 
Mon Feb  2 13:19:52 2009
@@ -172,6 +172,7 @@
      * @param pValue The field value to parse.
      * @return The result map; use the key "" to retrieve the first value.
      */
+    @SuppressWarnings("fallthrough")
     public static Map<String, String> getHeaderParams(String pValue) {
         pValue = pValue.trim();
         

Modified: 
james/mime4j/trunk/src/test/java/org/apache/james/mime4j/field/address/AddressTest.java
URL: 
http://svn.apache.org/viewvc/james/mime4j/trunk/src/test/java/org/apache/james/mime4j/field/address/AddressTest.java?rev=739988&r1=739987&r2=739988&view=diff
==============================================================================
--- 
james/mime4j/trunk/src/test/java/org/apache/james/mime4j/field/address/AddressTest.java
 (original)
+++ 
james/mime4j/trunk/src/test/java/org/apache/james/mime4j/field/address/AddressTest.java
 Mon Feb  2 13:19:52 2009
@@ -76,8 +76,8 @@
         assertEquals("Marketing  folks", group.getName());
         assertEquals(2, group.getMailboxes().size());
 
-        Mailbox mailbox1 = (Mailbox)group.getMailboxes().get(0);
-        Mailbox mailbox2 = (Mailbox)group.getMailboxes().get(1);
+        Mailbox mailbox1 = group.getMailboxes().get(0);
+        Mailbox mailbox2 = group.getMailboxes().get(1);
 
         assertEquals("Jane Smith", mailbox1.getName());
         assertEquals("jane", mailbox1.getLocalPart());