Hi Ioan,
Patch looks good to me, except that I wonder why you to introduce Guava
dependency:
- The Preconditions could be replace by a simple test.
- The InputStream asInputStreamUTF8Encoded() {return new
ByteBufferInputStream(Charsets.UTF_8.encode(messageBuffer));} is not
used in the project.
- The Charset charset = Charsets.UTF_8; could be replace with
Charset.forName("UTF_8")
It compiles/tests fine on jdk6 (not on my jdk7 which complains
@Override, but that's a bug on my env).
Thx, Eric
PS: For those willing to test from ioan' repo, don't forget 'git
checkout -b master origin/master' after 'git clone
https://github.com/ieugen/james-mime4j.git', svn's trunk in git's master).
On 06/16/2012 04:25 PM, Ioan Eugen Stan wrote:
Hello,
I've completed integrating mbox-iterator[1] into mime4j. I'm waiting 3
days for a code review before I do a push. The changes to mime4j are
in this change-set on github:
https://github.com/ieugen/james-mime4j/commit/8619b28297d8762913754fcee8ceb98caad5d218
I added an example of how you can use it with mime4j to parse mbox files.
I also bumped junit to 4.10.
Cheers,
[1] https://github.com/ieugen/mbox-iterator
--
eric | http://about.echarles.net | @echarles
