[ http://issues.apache.org/jira/browse/DIRMINA-201?page=all ] Robert Greig closed DIRMINA-201: --------------------------------
Changes look good to me. > Make the CumulativeProtocolDecoder "slice compatible" > ----------------------------------------------------- > > Key: DIRMINA-201 > URL: http://issues.apache.org/jira/browse/DIRMINA-201 > Project: Directory MINA > Type: Improvement > Versions: 0.9.3 > Reporter: Robert Greig > Assignee: Niklas Therning > Fix For: 0.9.4 > Attachments: CumulativeProtocolDecoder.java, CumulativeProtocolDecoder.java, > CumulativeProtocolDecoder.java.diff, SocketIoProcessor.java, > SocketIoProcessor.java.diff > > There is a problem with using slice() along with the > CumulativeProtocolDecoder. > The problem is that the CPD does a compact() when it has completed the > attempt to decode the buffer, and then reuses the buffer. > If your decoder expects to be able to take a slice() of the buffer and use > that it will find the data gets corrupted by the next call to the > CumulativeProtocolDecoder. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
