Send MinGW-Notify mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
https://lists.osdn.me/mailman/listinfo/mingw-notify
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of MinGW-Notify digest..."
Please do not reply to this notification; the sender address is unable to
accept incoming e-mail. If you wish to unsubscribe you can do so at
https://lists.osdn.me/mailman/listinfo/mingw-notify.
Today's Topics:
1. [SCM] mingw-org-wsl (mingw) branch, 5.1-trunk, updated.
7b0f1f23aa38ae883cded71ff30d94e31b4e39cb (MinGW Notification List)
2. [mingw] #38391: CALG_TLS1PRF in wincrypt.h unusable
(MinGW Notification List)
3. [mingw] #38391: CALG_TLS1PRF in wincrypt.h unusable
(MinGW Notification List)
----------------------------------------------------------------------
Message: 1
Date: Thu, 12 Jul 2018 19:23:54 +0900
From: MinGW Notification List <[email protected]>
Subject: [MinGW-Notify] [SCM] mingw-org-wsl (mingw) branch, 5.1-trunk,
updated. 7b0f1f23aa38ae883cded71ff30d94e31b4e39cb
To: [email protected]
Message-ID: <[email protected]>
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to "mingw-org-wsl" repository
containing the "mingw" project.
The branch, 5.1-trunk has been updated
via 7b0f1f23aa38ae883cded71ff30d94e31b4e39cb (commit)
via 73aedcc0f2e6ba370de0d86ab878ad76a0dda7b5 (commit)
from 753e249cdb3480951addf1c33151922cdd09705f (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 7b0f1f23aa38ae883cded71ff30d94e31b4e39cb
Author: Keith Marshall <[email protected]>
Date: Wed Jul 11 21:20:14 2018 +0100
Make <wincrypt.h> header effectively self-contained.
* include/wincrypt.h: Include <winbase.h>
commit 73aedcc0f2e6ba370de0d86ab878ad76a0dda7b5
Author: Keith Marshall <[email protected]>
Date: Wed Jul 11 21:07:05 2018 +0100
Correct <wincrypt.h> typographic errors; fix issue [#38391]
* include/wincrypt.h (CALG_TLS1PRF): Delete symbolic reference to...
(ALG_CLASS_DHASH): ...this; there is no such symbol; replace it with...
(ALG_CLASS_HASH): ...this, which represents the correct reference.
(struct _CRYPTOAPI_BLOB): Delete extraneous "typedef" keyword; this
struct definition is not directly associated with any type name.
(struct _SSL_EXTRA_CERT_CHAIN_POLICY_PARA): Likewise.
-----------------------------------------------------------------------
Summary of changes:
w32api/ChangeLog | 17 +++++++++++++++++
w32api/include/wincrypt.h | 14 ++++++++------
2 files changed, 25 insertions(+), 6 deletions(-)
hooks/post-receive
--
mingw-org-wsl (mingw)
------------------------------
Message: 2
Date: Thu, 12 Jul 2018 12:02:40 +0100
From: MinGW Notification List <[email protected]>
Subject: [MinGW-Notify] [mingw] #38391: CALG_TLS1PRF in wincrypt.h
unusable
To: OSDN Ticket System <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8
#38391: CALG_TLS1PRF in wincrypt.h unusable
Open Date: 2018-07-10 08:32
Last Update: 2018-07-12 12:02
URL for this Ticket:
https://osdn.net//projects/mingw/ticket/38391
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=3917&tid=38391
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2018-07-12 12:02 Updated by: keith
* Status Update from Open to Closed
* Resolution Update from None to Fixed
Comment:
My own (local) patch queue has a further issue to resolve, in <wincrypt.h> ?
two extraneous typedef keywords preceding struct definitions, with no directly
associated type name, in either case. I've folded the removal of these
extraneous typedefs into the patch to correct this bogus reference to
ALG_CLASS_DHASH.
I also have a trivial patch to make <wincrypt.h> effectively self-contained.
(Microsoft may not care about such niceties, but it is better software
engineering, and thus right and proper, that we do so).
I've gone ahead, and committed both of the attached patches, as commit
#73aedcc, and commit #7b0f1f2, respectively.
---------------------------------------------------------------------
Ticket Status:
Reporter: marcelraad
Owner: keith
Type: Issues
Status: Closed
Priority: 5 - Medium
MileStone: (None)
Component: WSL
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
I'm using w32api 5.0.2, but the issue is also in the trunk and experimental
branches.
CALG_TLS1PRF is defined as (ALG_CLASS_DHASH | ALG_TYPE_ANY | ALG_SID_TLS1PRF)
in
https://osdn.net/projects/mingw/scm/git/mingw-org-wsl/blobs/5.1-trunk/w32api/include/wincrypt.h.
This doesn't compile as ALG_CLASS_DHASH is not defined. The Microsoft Windows
SDK uses ALG_CLASS_HASH instead.
#include <windows.h>
#include <wincrypt.h>
int i = CALG_TLS1PRF;
results in
$ gcc test_wincrypt.c
In file included from test_wincrypt.c:2:0:
test_wincrypt.c:4:9: error: 'ALG_CLASS_DHASH' undeclared here (not in a
function)
int i = CALG_TLS1PRF;
^
--
Ticket information of MinGW - Minimalist GNU for Windows project
MinGW - Minimalist GNU for Windows Project is hosted on OSDN
Project URL: https://osdn.net/projects/mingw/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net//projects/mingw/ticket/38391
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=3917&tid=38391
------------------------------
Message: 3
Date: Thu, 12 Jul 2018 13:17:16 +0200
From: MinGW Notification List <[email protected]>
Subject: [MinGW-Notify] [mingw] #38391: CALG_TLS1PRF in wincrypt.h
unusable
To: OSDN Ticket System <[email protected]>
Message-ID: <[email protected]>
Content-Type: text/plain; charset=UTF-8
#38391: CALG_TLS1PRF in wincrypt.h unusable
Open Date: 2018-07-10 09:32
Last Update: 2018-07-12 13:17
URL for this Ticket:
https://osdn.net//projects/mingw/ticket/38391
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=3917&tid=38391
---------------------------------------------------------------------
Last Changes/Comment on this Ticket:
2018-07-12 13:17 Updated by: marcelraad
Comment:
Great, thanks for the fast fix!
---------------------------------------------------------------------
Ticket Status:
Reporter: marcelraad
Owner: keith
Type: Issues
Status: Closed
Priority: 5 - Medium
MileStone: (None)
Component: WSL
Severity: 5 - Medium
Resolution: Fixed
---------------------------------------------------------------------
Ticket details:
I'm using w32api 5.0.2, but the issue is also in the trunk and experimental
branches.
CALG_TLS1PRF is defined as (ALG_CLASS_DHASH | ALG_TYPE_ANY | ALG_SID_TLS1PRF)
in
https://osdn.net/projects/mingw/scm/git/mingw-org-wsl/blobs/5.1-trunk/w32api/include/wincrypt.h.
This doesn't compile as ALG_CLASS_DHASH is not defined. The Microsoft Windows
SDK uses ALG_CLASS_HASH instead.
#include <windows.h>
#include <wincrypt.h>
int i = CALG_TLS1PRF;
results in
$ gcc test_wincrypt.c
In file included from test_wincrypt.c:2:0:
test_wincrypt.c:4:9: error: 'ALG_CLASS_DHASH' undeclared here (not in a
function)
int i = CALG_TLS1PRF;
^
--
Ticket information of MinGW - Minimalist GNU for Windows project
MinGW - Minimalist GNU for Windows Project is hosted on OSDN
Project URL: https://osdn.net/projects/mingw/
OSDN: https://osdn.net
URL for this Ticket:
https://osdn.net//projects/mingw/ticket/38391
RSS feed for this Ticket:
https://osdn.net/ticket/ticket_rss.php?group_id=3917&tid=38391
------------------------------
_______________________________________________
MinGW-Notify mailing list
[email protected]
https://lists.osdn.me/mailman/listinfo/mingw-notify
End of MinGW-Notify Digest, Vol 10, Issue 3
*******************************************
