2011/9/14 Ozkan Sezer <seze...@gmail.com>: > On Wed, Sep 14, 2011 at 10:23 AM, Kai Tietz <ktiet...@googlemail.com> wrote: >> 2011/9/14 Vincent Torri <vincent.to...@gmail.com>: >>> >>> >>> On Wed, Sep 14, 2011 at 9:02 AM, Ozkan Sezer <seze...@gmail.com> wrote: >>>> >>>> On Wed, Sep 14, 2011 at 9:51 AM, Vincent Torri <vincent.to...@gmail.com> >>>> wrote: >>>> > Hey >>>> > >>>> > here is a patch that adds LIST_MODULES_* values in psapi.h. See >>>> > http://msdn.microsoft.com/en-us/library/ms682633%28v=VS.85%29.aspx >>>> > >>>> > Vincent Torri >>>> >>>> Why are you using ifdefs ?? >>> >>> Kai told me to use them >>> >>>> >>>> As for LIST_MODULES_ALL, defining as >>>> (LIST_MODULES_32BIT|LIST_MODULES_64BIT) would be >>>> more eye friendly as opposed to 0x3, IMO. >>> >>> why not. Feel free to modify the patch >>> >>> Vincent Torri >>> >>>> >>>> -- >>>> O.S. >> >> The cause for this ifdef's might be that user might have defined those >> values h(im/er)self. To use here an unnamed enumerator looks to me >> wrong here, so I prefer defines for those constants >> >> Nevertheless patch looks ok, but Ozkan, if you want to alter it, feel >> free to do so. >> >> Regards, >> Kai > > Hand-edited patch inlined below: Fixed the 64 bit definition, > changed the _ALL definition to OR'ed _32 and _64 defs. > > --- psapi.h 2011-09-14 06:20:12 +0000 > +++ psapi_new.h 2011-09-14 06:48:47 +0000 > @@ -21,6 +21,19 @@ > #define EnumPageFiles __MINGW_NAME_AW(EnumPageFiles) > #define GetProcessImageFileName __MINGW_NAME_AW(GetProcessImageFileName) > > +#ifndef LIST_MODULES_DEFAULT > +#define LIST_MODULES_DEFAULT 0x0 > +#endif > +#ifndef LIST_MODULES_32BIT > +#define LIST_MODULES_32BIT 0x01 > +#endif > +#ifndef LIST_MODULES_64BIT > +#define LIST_MODULES_64BIT 0x02 > +#endif > +#ifndef LIST_MODULES_ALL > +#define LIST_MODULES_ALL (LIST_MODULES_32BIT|LIST_MODULES_64BIT) > +#endif > + > WINBOOL WINAPI EnumProcesses(DWORD *lpidProcess,DWORD cb,DWORD *cbNeeded); > WINBOOL WINAPI EnumProcessModules(HANDLE hProcess,HMODULE > *lphModule,DWORD cb,LPDWORD lpcbNeeded); > DWORD WINAPI GetModuleBaseNameA(HANDLE hProcess,HMODULE > hModule,LPSTR lpBaseName,DWORD nSize); > > -- > O.S.
Ok, thanks. Patch is ok for trunk and IMHO for v2.x. About 1.x I am not sure if this is worth. Kai ------------------------------------------------------------------------------ BlackBerry® DevCon Americas, Oct. 18-20, San Francisco, CA Learn about the latest advances in developing for the BlackBerry® mobile platform with sessions, labs & more. See new tools and technologies. Register for BlackBerry® DevCon today! http://p.sf.net/sfu/rim-devcon-copy1 _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
