On 07/16/12 11:02, Ozkan Sezer wrote: > On Mon, Jul 16, 2012 at 11:33 AM, Jacek Caban <ja...@codeweavers.com> wrote: >> On 07/15/12 14:21, Nicolas Le Cam wrote: >>> 2012/7/4 Jacek Caban <ja...@codeweavers.com>: >>>> On 07/03/12 20:10, Jacek Caban wrote: >>>>> On 06/29/12 03:35, Austin English wrote: >>>>>> On Thu, Jun 28, 2012 at 6:30 PM, Nicolas Le Cam <niko.le...@gmail.com> >>>>>> wrote: >>>>>>> 2012/6/29 Austin English <austinengl...@gmail.com>: >>>>>>>> Fixes http://bugs.winehq.org/show_bug.cgi?id=30980 >>>>>>>> >>>>>>>> -- >>>>>>>> -Austin >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> Hi Austin, >>>>>>> >>>>>>> I already tried to fix it on Wine side, see [1], >>>>>>> but Alexandre told me on IRC that the bug needs to be fixed in >>>>>>> mingw-w64, >>>>>>> as it shouldn't include crtdefs.h by default. >>>>>>> >>>>>>> BTW, won't that break mingw32 build ? >>>>>>> >>>>>>> [1] http://source.winehq.org/patches/data/84070 >>>>>>> >>>>>>> -- >>>>>>> Nicolas Le Cam >>>>>> Thanks for the info. Have you or anyone else discussed this with >>>>>> mingw64? I did a quick search on their bugtracker, but don't see >>>>>> anything.. >>>>>> http://sourceforge.net/search/?group_artifact_id=983354&type_of_search=artifact&group_id=202880&words=crtdefs >>>>> FWIW, here is my proposed patch to mingw-w64: >>>>> >>>>> http://repo.or.cz/w/mingw-w64/jacek.git/commitdiff/5db96424c7b9ac4aa5a66bd0e9724740624bf96f >>>>> >>>>> We will see if they like it. >>>> The (extended) fix is in mingw-w64 SVN now. >>>> >>>> Jacek >>>> >>>> >>>> >>>> >>> Hi Jacek, >>> >>> Could it be backported into stable 2.x ? This will allow distros to >>> package it with the next stable release of mingw-w64. >> I'm not sure bout that, it's quite an invasive change, so it may be too >> risky for stable branch. I'm CCing mingw-w64 ML to see what maintainers >> think. > The repo.cz link gives "404 - Unknown commit object". If this is the > crtdefs.h commit that went into the trunk,
Yes, that's this commit. For the reference, here is the committed diff: http://repo.or.cz/w/mingw-w64/jacek.git/commitdiff/8c4da30fd44a7a47e7ba64a0c461d409146b6ae3 > if the admins are OK with it > then I am OK with it, too and feel free to test a patch and commit in > that case. OK, thanks. Jacek ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
