On Aug 16 08:16, NightStrike wrote:
> On Tue, Aug 14, 2012 at 3:30 AM, Corinna Vinschen <[email protected]> wrote:
> >> Index: configure.ac
> >> ===================================================================
> >> --- configure.ac (revision 5352)
> >> +++ configure.ac (working copy)
> >> @@ -16,12 +16,12 @@
> >> AC_MSG_CHECKING([for sysroot])
> >> AC_ARG_WITH([sysroot],
> >> [AS_HELP_STRING([--with-sysroot=DIR],
> >> - [Search for headers within DIR/include (default: prefix/include)])],
> >> + [Search for headers within DIR/include (default: prefix)])],
>
> Definitely a bug. Good catch.
>
> >> [],
> >> - [AS_VAR_SET([with_sysroot],[yes])])
> >> + [AS_VAR_SET([with_sysroot],[no])])
>
> For a long time, building with a sysroot was the default case. To
> build without one (ie, to use /usr/include) requires
> --without-sysroot. Is the consensus that that is no longer the
> desired default? That's a big change.
>
> >> AS_CASE([$with_sysroot],
> >> [no],[],
> >> - [yes],[AS_VAR_SET([with_sysroot],[$prefix/include])],
> >> + [yes],[AS_VAR_SET([with_sysroot],[$prefix])],
> >> [])
> >> AC_MSG_RESULT([$with_sysroot])
> >>
> >> AS_VAR_IF([with_sysroot],[no],[],[AS_VAR_SET([TARGET_SYSTEM_ROOT],[$with_sysroot])])
>
> Even if I agreed with the with-sysroot default, these should be
> committed as two separate things. So, approved for the /include bug.
> We should talk about the with-sysroot default. I'm interested to hear
> what Ozkan and Ruben have to say.
Thanks, I applied the /include fix.
As for sysroot, I seriously don't understand what it's good for to set
sysroot == prefix. This is not at all what sysroot is supposed to be.
prefix is supposed to be relative to sysroot, the full path is
$sysroot/$prefix.
The default setting for sysroot is usually the system's root, which is
"/" (or better "" for path evaluation reasons) or its non-POSIX
counterpart. So, assuming prefix is /usr, for a native system the
result of $sysroot/$prefix is /usr. For a cross toolchain you change
the sysroot accordingly. For instance, for the Fedora Mingw cross
you set sysroot to "/usr/${cpu}-w64-mingw32/sys-root" and prefix to
"/mingw", so youll find the include and lib dirs under
/usr/${cpu}-w64-mingw32/sys-root/mingw.
Btw., any chance you could review the revised patch from
http://sourceforge.net/mailarchive/message.php?msg_id=29645305 ?
Thanks,
Corinna
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
