On 7/23/2013 17:03, Jacek Caban wrote:
> On 07/20/13 03:57, JonY wrote:
>> Hi,
>>
>> Cygwin errno.h does not define non-Posix errno_t, neither does Cygwin
>> stdlib.h knows about _invalid_parameter_handler.
>>
>> In theory, any Cygwin code should not be using libmsvcrt.a at all, but
>> this is currently a stopgap measure while I investigate how old the
>> libmsvcrt.a inclusion goes.
> 
> That's mostly a question to Cygwin devs, but don't they want -lmsvcrt to
> work if someone really wants it? It would mean that we should provide
> libmsvcrt.a in Cygwin builds.
> 

Sure, for now, libmsvcrt.a builds like normal for cygwin, just that it
shouldn't really be used, since Cygwin CRT comes from newlib instead.

>> The attached patch OK to commit?
> 
> configure.ac part seems unrelated to the problem. I think that's something 
> for Corinna and/or NightStrike to review.
> 

It is, so on 64bit Cygwin, 64bit libs go into /lib instead of /lib64,
lib is native bitness. This was written up before there were any
concrete plans for 64bit Cygwin.

> The other part of the patch doesn't really need to introduce 
> _INVALID_PARAMETER_HANDLER_DEFINED in a public header. You may simply remove 
> stdlib.h include from invalid_parameter_handler.c and always typedef 
> _invalid_parameter_handler or simly use void* instead of 
> _invalid_parameter_handler. BTW, indeally our crt libs should use our crt 
> headers on Cygwin builds, IMO. That would solve similar problems, but I guess 
> that would be tricky (I haven't done any Cygwin builds myself, so I don't 
> know much about them).

Simply adding the typedefs looks to be the simplest fix. As mentioned
earlier, Cygwin has its own CRT, the mingw-w64 parts are used for win32
APIs.


Attachment: signature.asc
Description: OpenPGP digital signature

------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to