Hi, thanks for the review.
2013/12/4 JonY <[email protected]>: > On 12/5/2013 04:17, Kai Tietz wrote: >> Hi, >> >> could somebody of you please review http://pastebin.com/w91sSRk0 >> >> Thanks, >> Kai >> > > Is this correct? CONST to const > > - POINT CONST *pptDst; > - SIZE CONST *psize; > + const POINT *pptDst; > + const SIZE *psize; > > What is this part about? Nothing special. In general is the way of writing 'const <type>' to be preferred over the form of '<type> const'. This is a clarification. > - WINUSERAPI WINBOOL WINAPI UpdateLayeredWindowIndirect(HWND > hWnd,UPDATELAYEREDWINDOWINFO CONST *pULWInfo); > +#if _WIN32_WINNT < 0x0502 > + typedef > +#endif > + WINUSERAPI WINBOOL WINAPI UpdateLayeredWindowIndirect (HWND hWnd, const > UPDATELAYEREDWINDOWINFO *pULWInfo); > +#endif > +#endif WINVER? In the line above I see _WIN32_WINNT here ... well, the use of those both makros is a mix ... I used those referenced, but I agree that I didn't found a good master plan, when MS uses which one. Well, WINVER is defined by some headers itself as default, but _WIN32_WIN32 is just defined in the sdk-headers ... > Suddenly WINVER? I also see a lot of changes initially to put #if inside > brackets, > why stop there? The brackets are superflous. So I removed them from lines, which I touched. We don't write Lisp ;) > +#if WINVER >= 0x0600 > + WINUSERAPI WINBOOL WINAPI AddClipboardFormatListener (HWND hwnd); > + WINUSERAPI WINBOOL WINAPI RemoveClipboardFormatListener (HWND hwnd); > + WINUSERAPI WINBOOL WINAPI GetUpdatedClipboardFormats (PUINT lpuiFormats, > UINT cFormats, PUINT pcFormatsOut); > #endif > +#endif > > These kind of mean differently They are right AFAICS. What's the comment here about? Those clipboard-functions are available beginning from Vista. > -#if (_WIN32_WINNT < 0x0600) > -#define SM_CMETRICS 90 > +#if WINVER <= 0x501 > +#define SM_CMETRICS 91 > +#elif WINVER == 0x600 > +#define SM_CMETRICS 93 > +#else > +#define SM_CMETRICS 97 > #endif This is actual a bug fix. We handled that wrong in the past. See code above it to see the obvious cause for this change. > CreateDesktopA/W removed?? > > -WINUSERAPI HDESK WINAPI CreateDesktopExA( > - LPCSTR lpszDesktop, > - LPCSTR lpszDevice, > - DEVMODE *pDevmode, > - DWORD dwFlags, > - ACCESS_MASK dwDesiredAccess, > - LPSECURITY_ATTRIBUTES lpsa, > - ULONG ulHeapSize, > - PVOID pvoid > -); It isn't removed, just moved to different place in header. As I wrote, I corected, consolidated, and verified header. You can find CreateDesktopA/W next to its extended variant, next to the other ...Desktop functions. Cheers, Kai ------------------------------------------------------------------------------ Sponsored by Intel(R) XDK Develop, test and display web and hybrid apps with a single code base. Download it for free now! http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
