2013/12/16 Ruben Van Boxem <[email protected]>
> 2013/12/16 Alexey Pavlov <[email protected]>
>
>> 2013/12/16 Ruben Van Boxem <[email protected]>:
>> > 2013/12/16 niXman <[email protected]>
>> >>
>> >> Ruben Van Boxem 2013-12-16 13:34:
>> >> > Hi,
>> >> >
>> >> > Quick question: does the GNU Make 4.0 release mean I don't need to
>> >> > patch
>> >> > the hell out of GNU Make anymore to make it function decently in a
>> >> > Windows
>> >> > environment, or are there still outstanding issues with it? If so,
>> what
>> >> > patches would you recommend?
>> >> The scripts[1] apply the patches themselves. Or what you mean?
>> >>
>> >> [1] https://github.com/niXman/mingw-builds/tree/develop
>> >>
>> >
>> > I mean that those patches are 8 months old, and GNU Make 4.0 is out and
>> I'm
>> > wondering if they're still relevant. And if they are, have they been
>> > signalled upstream?
>>
>> There are only two patches needed
>>
>>
>> https://github.com/niXman/mingw-builds/blob/develop/scripts/make_git_bat.sh#L50-L51
>>
>
I'm running into the strangest thing. Whatever I do to apply the getopt
patch, it will always fail on hunk 2 and 3. I have taken it from
mingw-builds, sezero's version at Savannah, my version in
MinGW-w64-build-scripts, and even multiply tried to get a manual working
diff.
I feel stupid. Attached is the -p0 patch I ended up with after manually
applying the changes and running diff -upr.
Anyone know what's going wrong?
Thanks,
Ruben
>
>> But we build make from git.
>> If you want build released GNU Make-4.0 you also need:
>>
>> https://projects.archlinux.org/svntogit/packages.git/tree/trunk/make-4.0-char-cast.patch?h=packages/make
>>
>
> Just what I needed.
>
> Thanks!
>
> Ruben
>
>
>> Regards,
>> Alexey.
>> >
>> > Cheers,
>> >
>> > Ruben
>> >
>> >
>> ------------------------------------------------------------------------------
>> > Rapidly troubleshoot problems before they affect your business. Most IT
>> > organizations don't have a clear picture of how application performance
>> > affects their revenue. With AppDynamics, you get 100% visibility into
>> your
>> > Java,.NET, & PHP application. Start your 15-day FREE TRIAL of
>> AppDynamics
>> > Pro!
>> >
>> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
>> > _______________________________________________
>> > Mingw-w64-public mailing list
>> > [email protected]
>> > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>> >
>>
>>
>> ------------------------------------------------------------------------------
>> Rapidly troubleshoot problems before they affect your business. Most IT
>> organizations don't have a clear picture of how application performance
>> affects their revenue. With AppDynamics, you get 100% visibility into your
>> Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics
>> Pro!
>>
>> http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
>> _______________________________________________
>> Mingw-w64-public mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>
>
>
--- getopt.c
+++ getopt.c
@@ -434,6 +434,9 @@ _getopt_initialize (int argc, char *cons
}
else
nonoption_flags_len = 0;
+#else
+ (void)argc;
+ (void)argv;
#endif
return optstring;
@@ -676,7 +679,7 @@ _getopt_internal (int argc, char *const
optarg = nameend + 1;
else
{
- if (opterr)
+ if (opterr) {
if (argv[optind - 1][1] == '-')
/* --option */
fprintf (stderr,
@@ -688,6 +691,7 @@ _getopt_internal (int argc, char *const
_("%s: option '%c%s' doesn't allow an argument\n"),
argv[0], argv[optind - 1][0], pfound->name);
+ }
nextchar += strlen (nextchar);
optopt = pfound->val;
--- main.c
+++ main.c
@@ -1105,8 +1105,11 @@ main (int argc, char **argv, char **envp
#endif
+/* setlocale interferes with line buffering if using parallel make on MinGW */
+#ifndef __MINGW32__
/* Set up gettext/internationalization support. */
setlocale (LC_ALL, "");
+#endif
/* The cast to void shuts up compiler warnings on systems that
disable NLS. */
(void)bindtextdomain (PACKAGE, LOCALEDIR);
--- makeint.h
+++ makeint.h
@@ -409,7 +409,7 @@ extern int unixy_shell;
# define MAP_VMSCOMMA 0x0000
#endif
-#define STOP_SET(_v,_m) ANY_SET (stopchar_map[(int)(_v)],(_m))
+#define STOP_SET(_v,_m) ANY_SET (stopchar_map[(unsigned char)(_v)],(_m))
#if defined(HAVE_SYS_RESOURCE_H) && defined(HAVE_GETRLIMIT) &&
defined(HAVE_SETRLIMIT)
# define SET_STACK_SIZE
------------------------------------------------------------------------------
CenturyLink Cloud: The Leader in Enterprise Cloud Services.
Learn Why More Businesses Are Choosing CenturyLink Cloud For
Critical Workloads, Development Environments & Everything In Between.
Get a Quote or Start a Free Trial Today.
http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public