On Fri, Nov 7, 2014 at 9:48 PM, Ruben Van Boxem <[email protected]> wrote: > 2014-11-07 14:45 GMT+01:00 Dongsheng Song <[email protected]>: >> >> On Fri, Nov 7, 2014 at 4:44 PM, lh_mouse <[email protected]> wrote: >> > Minor suggestion: use the word `DECLARED` instead `DEFINED` please. >> > >> >> I don't known which is better:-) >> Here is some stats: >> >> $ grep -r "_DEFINED[^A-Z0-9]" . | wc -l >> 26145 >> >> $ grep -r "_DECLARED[^A-Z0-9]" . | wc -l >> 15 > > > That bit in your patch is clearly declaring a function. I don't see how a > pop poll helps decide proper wording? > > Ruben >
I following the previous usage. $ cat mingw-w64-headers/crt/unistd.h | grep _DEFINED #ifndef FTRUNCATE_DEFINED #define FTRUNCATE_DEFINED #endif /* FTRUNCATE_DEFINED */ #ifndef _CRT_SWAB_DEFINED #define _CRT_SWAB_DEFINED /* Also in stdlib.h */ #ifndef _CRT_GETPID_DEFINED #define _CRT_GETPID_DEFINED /* Also in process.h */ ------------------------------------------------------------------------------ _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
