Yes. I don't think it's a problem that one GUID would be different, it
would be just a good example for future improvements, but your patch is
fine as well.
On 02/04/15 17:13, Martell Malone wrote:
> Will I consider this reviewed?
> Just need the go ahead
>
> On Wed, Feb 4, 2015 at 3:23 PM, Martell Malone
> <[email protected] <mailto:[email protected]>> wrote:
>
> I know that it's not what we do in other cases, but something
> like that
> would avoid hardcoding this uuid in two places:
>
> DEFINE_GUID(KSCATEGORY_
> ENCODER, STATIC_KSCATEGORY_ENCODER);
>
>
> Yes I was going todo it that way but I saw that many of the others
> from that header were defined already and with the full string
> So I didn't want todo it just for this one GUID
>
> On Wed, Feb 4, 2015 at 3:18 PM, Jacek Caban <[email protected]
> <mailto:[email protected]>> wrote:
>
> Hi Martell,
>
> Those patches look good to me now. I just have one suggestion.
>
> On 02/04/15 16:14, Martell Malone wrote:
> >
>
> DEFINE_GUID(KSCATEGORY_DATADECOMPRESSOR,0x2721ae20,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
> >
>
> DEFINE_GUID(KSCATEGORY_DATATRANSFORM,0x2eb07ea0,0x7e70,0x11d0,0xa5,0xd6,0x28,0xdb,0x4,0xc1,0,0);
> >
>
> +DEFINE_GUID(KSCATEGORY_ENCODER,0x19689bf6,0xc384,0x48fd,0xad,0x51,0x90,0xe5,0x8c,0x79,0xf7,0xb);
>
> I know that it's not what we do in other cases, but something
> like that
> would avoid hardcoding this uuid in two places:
>
> DEFINE_GUID(KSCATEGORY_ENCODER, STATIC_KSCATEGORY_ENCODER);
>
> Thanks,
> Jacek
>
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming. The Go Parallel
> Website,
> sponsored by Intel and developed in partnership with Slashdot
> Media, is your
> hub for all things parallel software development, from weekly
> thought
> leadership blogs to news, videos, case studies, tutorials and
> more. Take a
> look and join the conversation now.
> http://goparallel.sourceforge.net/
> _______________________________________________
> Mingw-w64-public mailing list
> [email protected]
> <mailto:[email protected]>
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>
>
>
>
>
> ------------------------------------------------------------------------------
> Dive into the World of Parallel Programming. The Go Parallel Website,
> sponsored by Intel and developed in partnership with Slashdot Media, is your
> hub for all things parallel software development, from weekly thought
> leadership blogs to news, videos, case studies, tutorials and more. Take a
> look and join the conversation now. http://goparallel.sourceforge.net/
>
>
> _______________________________________________
> Mingw-w64-public mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
------------------------------------------------------------------------------
Dive into the World of Parallel Programming. The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net/
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
