Hi, thanks for pinging on this. Patch is ok. JonY could you apply it? It might be something for 4.x branch, too.
Thanks, Kai 2015-08-28 16:49 GMT+02:00 David Grayson <[email protected]>: > Could someone apply this patch? Right now, CHAR_MIN and CHAR_MAX will be > incorrect if gcc is invoked with the -funsigned-char option. This patch > fixes it to comply with section 5.2.4.2.1.2 of C11 (N1570), which says: > >> If the value of an object of type char is treated as a signed integer >> when used in an expression, [...cut...]. >> Otherwise, the value of CHAR_MIN shall be 0 and the value of CHAR_MAX >> shall be the same as that of UCHAR_MAX. > > > I don't actually use -funsigned-char, but I imagine there is legacy code out > there that uses it, and would be compiled incorrectly without this patch. > > We discussed this same patch on August 3. Jacek Caban said: > >> I'm not sure about this, but it probably makes sense. IMO it would be >> nice to have it in a separated commit and commented by Kai. > > > Thanks! > > --David Grayson > > ------------------------------------------------------------------------------ > > _______________________________________________ > Mingw-w64-public mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/mingw-w64-public > ------------------------------------------------------------------------------ _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
