Hi Ruben,

I'm sorry I didn't look at this earlier.

I committed winerror.h (it seems that you included the same defines in
two different places in those patches, so please retest with committed
version) and wincodec.idl parts.

However, dwrite_2.h needs some more work. We try to provide dwrite APIs
for plain C, which makes things a bit more painful than that. You need
to add THIS (for functions with no arguments) or THIS_ macros in the
beginning of declaration of each functions. Also to preserve proper vtbl
layout, declaration of parent interface needs to be copied inside
__cplusplus guard. See other declarations for an example. Also we try to
avoid using things like _In_, _Out_ macros in our headers.

Thanks,
Jacek

On 24.08.2016 18:25, Ruben Van Boxem wrote:
> I would like to reiterate my request to include the following the changes
> in MinGW-w64. I have no commit rights, and Kai half-OKed them, so input
> from someone in the team that can commit them directly would be greatly
> appreciated!
>
> I'll attach both patches (which are required to build Skia with MinGW-w64)
> to this email for convenience. Note there were duplicate GUID's in the
> previous patch, those were removed here.
>
> Please OK and apply so I can stop keeing my custom builds of MinGW-w64
> around, thanks :)
>
> Cheers!
>
> Ruben
>
> 2016-08-09 19:44 GMT+02:00 Ruben Van Boxem <vanboxem.ru...@gmail.com>:
>
>> Hi Kai (and Jacek),
>>
>> Thanks for taking a look.
>>
>> Note there are two patches: one I linked to in the body of my email, the
>> other was attached. Both would need to be applied by someone (I don't have
>> commit rights).
>>
>> Cheers,
>>
>> Ruben
>>
>> 2016-08-09 10:58 GMT+02:00 Kai Tietz <ktiet...@googlemail.com>:
>>
>>> Hi Ruben,
>>>
>>> patch looks fine to me.  As long as there are no objections (Jacek  do
>>> you?), go ahead and apply.
>>>
>>> Thanks,
>>> Kai
>>>
>>> 2016-08-08 20:57 GMT+02:00 Ruben Van Boxem <vanboxem.ru...@gmail.com>:
>>>> Hi guys,
>>>>
>>>> it would be nice to keep up to date with new APIs that gain real world
>>> use,
>>>> like this little patch:
>>>> https://github.com/Alexpux/mingw-w64/pull/1/commits/6c0efe37
>>> b32510f72020e38726c7a84690a926fd
>>>> Which is now needed for Qt 5.7 (and skia).
>>>>
>>>> I would also like to point out attached patch that adds various GUIDs
>>>> missing I ran into when compiling skia.
>>>>
>>>> Cheers,
>>>>
>>>> Ruben
>>>>
>>>> ------------------------------------------------------------
>>> ------------------
>>>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>>> traffic
>>>> patterns at an interface-level. Reveals which users, apps, and
>>> protocols are
>>>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>>>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>>>> planning reports. http://sdm.link/zohodev2dev
>>>> _______________________________________________
>>>> Mingw-w64-public mailing list
>>>> Mingw-w64-public@lists.sourceforge.net
>>>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>>>
>>> ------------------------------------------------------------
>>> ------------------
>>> What NetFlow Analyzer can do for you? Monitors network bandwidth and
>>> traffic
>>> patterns at an interface-level. Reveals which users, apps, and protocols
>>> are
>>> consuming the most bandwidth. Provides multi-vendor support for NetFlow,
>>> J-Flow, sFlow and other flows. Make informed decisions using capacity
>>> planning reports. http://sdm.link/zohodev2dev
>>> _______________________________________________
>>> Mingw-w64-public mailing list
>>> Mingw-w64-public@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
>>>
>>
>>
>>
>> ------------------------------------------------------------------------------
>>
>>
>> _______________________________________________
>> Mingw-w64-public mailing list
>> Mingw-w64-public@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


------------------------------------------------------------------------------
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to