Sounds like I've misinterpreted the correct usage of VALID_SYMBOLIC_LINK_FLAGS. Apologies! I've attached an amended patch in the event that's helpful.
Kind regards, Samuel Leslie -----Original Message----- From: Liu Hao [mailto:[email protected]] Sent: Sunday, 28 May 2017 8:35 AM To: [email protected]; JonY <[email protected]> Subject: Re: [Mingw-w64-public] [PATCH] Add flag for symlink creation by unprivileged users On 2017/5/27 21:35, JonY wrote: > On 05/27/2017 11:14 AM, Samuel Leslie wrote: >> The MSDN documentation doesn't appear to have been updated yet: >> https://msdn.microsoft.com/en-us/library/windows/desktop/aa363866(v=v >> s.85).aspx >> >> But you can find the details on the official developer blog: >> https://blogs.windows.com/buildingapps/2016/12/02/symlinks-windows-10 >> / >> > > Patch looks good. I don't think so... ``` C:\Program Files (x86)\Windows Kits>grep -FnrI VALID_SYMBOLIC_LINK_FLAGS 10/Include/10.0.14393.0/um/WinBase.h:8636:#define VALID_SYMBOLIC_LINK_FLAGS SYMBOLIC_LINK_FLAG_DIRECTORY // & whatever other flags we think of! 8.1/Include/um/WinBase.h:8515:#define VALID_SYMBOLIC_LINK_FLAGS SYMBOLIC_LINK_FLAG_DIRECTORY // & whatever other flags we think of! ``` It is the definition of `SYMBOLIC_LINK_FLAG_ALLOW_UNPRIVILEGED_CREATE` that looks good. The definition of `VALID_SYMBOLIC_LINK_FLAGS` should be left intact. -- Best regards, LH_Mouse ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public ------------------------------------------------------------------------------ Check out the vibrant tech community on one of the world's most engaging tech sites, Slashdot.org! http://sdm.link/slashdot _______________________________________________ Mingw-w64-public mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
