Hi Ebrahim,

#ifndef __cplusplus inside IDWriteTextAnalyzer1 should be around all parent interfaces' methods (IDWriteTextAnalyzer in this case), not just IUnknown.


Thanks,

Jacek


On 3/14/18 12:19 AM, Ebrahim Byagowi wrote:
Spotted one minor issue on the patch, here is another

On Wed, Mar 14, 2018 at 12:29 AM, Ebrahim Byagowi <ebrami...@gmail.com>
wrote:

Hi there. Following https://github.com/Alexpux/mingw-w64/pull/5 I am
sending my work here, this patch allows harfbuzz's hb-directwrite
<https://github.com/harfbuzz/harfbuzz/blob/master/src/hb-directwrite.cc>
build on msys2, I hope this change can be applied to both
"/msys2/usr/Include/win32api/dwrite_1.h" and 
"/mingw64/x86_64-w64-mingw32/include/dwrite_1.h".
Let me know what else is needed in order to make this happen. Thanks!

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public


------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to