On Wed, 27 Jun 2018, Jacek Caban wrote:
Hello,
On 27/06/2018 07:52, Martin Storsjö wrote:
I did a test build with this patch, and it failed at building winpthreads,
with the following error:
Yeah, I can reproduce problems. Sorry for not catching it earlier, initial
testing looked promising.
And just to make it clear - this is code that builds fine with clang+lld as
things stand right now (without -fms-extensions anywhere).
What was the exact issue you're trying to fix by tweaking the __forceinline
define?
It's the extern part that I tried to get rid of. With the current definition,
you can't use it like:
static int __forceinline func() { ... }
because static would conflict with extern. If __forceinline could avoid
extern and use only attributes (inline, gnu_inline, always_inline - it
doesn't matter in this aspect), it would be fine.
Ah, I see.
And for the firefox case, did you fix it by adding -fms-extensions?
No, I don't use -fms-extensions for those builds yet. I plan to revisit that
later, but for the initial work, I skipped it.
Ok. Earlier when I've looked at it, -fms-extensions breaks way too much of
everything that mingw is built on, so I've just steered clear of it. If it
can be made to work, it would of course be good to have the option, even
though I'd also prefer libs/apps to be buildable in mingw mode without it.
My toolchain, however, does not contain winpthreads. libc++ doesn't need it
to support threads. It does native Windows calls for what it needs, so I
don't need winpthreads.
Yes, I know - I don't need winpthreads myself either, for the exact same
reasons. A user of my toolchain wanted winpthreads to build code of his
own though, code that didn't contain windows threads abstractions. So I'm
building and bundling it as an optional add-on only.
// Martin
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
