Hi Alexey,
I'm sorry for so late reply. It looks mostly good, but I spotted a few
comments. Other than that, it looks good to me, thanks!
On 07/18/2018 02:49 PM, Alexey Pavlov wrote:
>
> + D3DFMT_V16U16 = 64,
> + D3DFMT_W11V11U10 = 65,
> + D3DFMT_A2W10V10U10 = 67,
> +/*
> + D3DFMT_UYVY = MAKEFOURCC('U', 'Y', 'V', 'Y'),
> + D3DFMT_YUY2 = MAKEFOURCC('Y', 'U', 'Y', '2'),
> + D3DFMT_DXT1 = MAKEFOURCC('D', 'X', 'T', '1'),
> + D3DFMT_DXT2 = MAKEFOURCC('D', 'X', 'T', '2'),
> + D3DFMT_DXT3 = MAKEFOURCC('D', 'X', 'T', '3'),
> + D3DFMT_DXT4 = MAKEFOURCC('D', 'X', 'T', '4'),
> + D3DFMT_DXT5 = MAKEFOURCC('D', 'X', 'T', '5'),
> +*/
Those are comments, we don't need them and I don't think we want (or
even should) be comments-compatible with MS headers. Please remove those.
> +cpp_quote("")
> +typedef enum _MFVideoMixPrefs {
> + MFVideoMixPrefs_ForceHalfInterlace = 0x00000001,
> + MFVideoMixPrefs_AllowDropToHalfInterlace = 0x00000002,
> + MFVideoMixPrefs_AllowDropToBob = 0x00000004,
> + MFVideoMixPrefs_ForceBob = 0x00000008,
> + MFVideoMixPrefs_EnableRotation = 0x00000010,
> + MFVideoMixPrefs_Mask = 0x0000000f
> +} MFVideoMixPrefs;
_Mask should be 0x1f.
> +cpp_quote("")
> +cpp_quote("#if MFEVRDLL")
> +cpp_quote("#define EVRPUBLIC(func) STDAPI _##func")
> +cpp_quote("#else" )
> +cpp_quote("#define EVRPUBLIC(func) STDAPI func")
> +cpp_quote("#endif")
I'm not sure we want those MFEVRDLL and EVRPUBLIC macros. It looks like
something MS may need for some internal stuff like implementing the DLL
itself.
Thanks,
Jacek
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
