在 2019/3/7 13:08, Ruslan Garipov 写道: > Signed-off-by: Ruslan Garipov <ruslanngari...@gmail.com> > --- > mingw-w64-crt/Makefile.in | 4 +-
Next time, please do not include the diff of generated files.
'Makefile.in' is generated from 'Makefile.am' using `autoreconf -if' so
only the diff of 'Makefile.am' need appear in the patch. I removed this
from the patch.
For this patch there is no modification to 'Makefile.am', however.
> mingw-w64-crt/lib32/Makefile.am | 1 +
> mingw-w64-crt/lib32/msoledbsql.def | 13 +
> mingw-w64-crt/lib64/Makefile.am | 1 +
> mingw-w64-crt/lib64/msoledbsql.def | 13 +
> mingw-w64-headers/include/msoledbsql.h | 1452 ++++++++++++++++++++++++
> 6 files changed, 1482 insertions(+), 2 deletions(-)
> create mode 100644 mingw-w64-crt/lib32/msoledbsql.def
> create mode 100644 mingw-w64-crt/lib64/msoledbsql.def
> create mode 100644 mingw-w64-headers/include/msoledbsql.h
>
> +#ifndef __cplusplus
> + MSOLEDBSQL_H_DECL_SSVARIANT_STRUCTS;
> +#endif
> +struct SSVARIANT {
> + SSVARTYPE vt;
> + DWORD dwReserved1;
> + DWORD dwReserved2;
> + /* For C++ code (`-x c++`/`-Tp`) we may move the declarations here. This,
> at
> + * least, limits scope of the declarations to the `SSVARIANT` structure,
> if we
> + * compare declaration of the structures at the global scope (as it's made
> for
> + * C code). Both variants break public API of the original header file,
> but
> + * unfortunately that's unavoidable. */
> +#ifdef __cplusplus
> + MSOLEDBSQL_H_DECL_SSVARIANT_STRUCTS;
> +#endif
There shall be no semicolons following
`MSOLEDBSQL_H_DECL_SSVARIANT_STRUCTS`. I removed them, too.
Thank you very much for the work and the discussion. The patch looks
good now. I amended the patch and pushed it.
--
Best regards,
LH_Mouse
signature.asc
Description: OpenPGP digital signature
_______________________________________________ Mingw-w64-public mailing list Mingw-w64-public@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
