在 2019/4/17 22:26, Biswapriyo Nath 写道:
> Signed-off-by: Biswapriyo Nath <[email protected]>
> ---
>  mingw-w64-crt/Makefile.am                        |  2 ++
>  mingw-w64-crt/Makefile.in                        |  2 ++

Next time, please do not include 'Makefile.in' in patches, because it is
generated from 'Makefile.am' and will be overwritten after all. If you
patch alters 'configure.ac' or 'Makefile.am' (maybe a few more) we will
regenerate these scripts and commit them as separated commits.


> diff --git a/mingw-w64-crt/lib-common/api-ms-win-core-console-l1-1-0.def 
> b/mingw-w64-crt/lib-common/api-ms-win-core-console-l1-1-0.def
> new file mode 100644
> index 00000000..ff64b1a2
> --- /dev/null
> +++ b/mingw-w64-crt/lib-common/api-ms-win-core-console-l1-1-0.def
> @@ -0,0 +1,16 @@
> +LIBRARY "api-ms-win-core-console-l1-1-0.dll"
> +EXPORTS
> +AllocConsole
> +GetConsoleCP
> +GetConsoleMode
> +GetConsoleOutputCP
> +GetNumberOfConsoleInputEvents
> +PeekConsoleInputA

This seems to come from 'api-ms-win-core-console-l1-2-0.dll' [1].
However, I have checked a few DLLs on my system - this function does
exist in them, so I presume it is safe to have it in this DEF.

[1] https://docs.microsoft.com/en-us/uwp/win32-and-com/win32-apis

> +ReadConsoleA
> +ReadConsoleInputA
> +ReadConsoleInputW
> +ReadConsoleW
> +SetConsoleCtrlHandler
> +SetConsoleMode
> +WriteConsoleA
> +WriteConsoleW


This patch looks good to me. I pushed to master. Thanks for the work.



-- 
Best regards,
LH_Mouse

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to