On Fri, 27 Sep 2019, Christian Franke wrote:

Christian Franke wrote:
Martin Storsjö wrote:
On Fri, 13 Sep 2019, Christian Franke wrote:

...
 __attribute__((__format__ (ms_printf, 3, 4))) __MINGW_ATTRIB_NONNULL(3)
-int snprintf (char * __restrict__ __stream, size_t __n, const char * __restrict__ __format, ...)
+int snprintf (char *__stream, size_t __n, const char *__format, ...)
 {

Technically, this bit of the patch is a stray change in this context.

Garbage from dropped previous patch, sorry. New version attached.


Any further issues with the new patch?

Sorry, I forgot about this after the other issue with gnu_inline was sorted out.

I guess this patch should be ok, as I presume it's a strict improvement for these cases, even if there still are potential corner cases with issues.

One part that I'm not entirely sure about here is why __mingw_va_arg_pack_ovr isn't needed as attribute on those functions any longer.

// Martin

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to