On 10/03/2020 07:34, Steve Lhomme wrote:
You mean squash all 5 patches into one or just the first two ?
In general I prefer to split commits so if something breaks it's
easier to know what is wrong in a particular commit and possibly
revert it, without losing all changes.
Splitting patches is generally a good habit, but only when it makes
sense. In this case, you know that the interface that you're adding in
patch 1 is broken (and you already have a fix for that), so how can we
review patch 1?
Please merge them all.
Thanks,
Jacek
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
