On Fri, 20 Mar 2020, Martin Storsjö wrote:

On Thu, 19 Mar 2020, Liu Hao wrote:

在 2020/3/19 23:02, Martin Storsjö 写道:
This fixes the same warning as d551b7d85ec63c0fa33f1a51ec5157722709fc53
(warnings due to declaring a variable as extern and initializing it
at the same time) tried to fix, without overriding the EXTERN_C macro,
which affected other headers.

Signed-off-by: Martin Storsjö <[email protected]>
---
 mingw-w64-headers/include/mftransform.h   | 58 ++++++++++++---------
 mingw-w64-headers/include/mftransform.idl | 62 ++++++++++++++---------
 2 files changed, 71 insertions(+), 49 deletions(-)




LGTM.

Thanks, will push tomorrow unless my testing shows that anything trips up by it.

BTW, do we have to commit the generated header in a separated patch
other than the IDL itself?

I guess it'd be nicer to separate it into functional change and autogeneration, but the revert commit contains both in the same. It's at least more readable than Makefile.in changes...

Pushed with both .h and .idl in the same commit, for easier revertability in case there's other issues found in it.

// Martin

_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to