On 19.05.2020 10:34, Martin Storsjö wrote:
On Mon, 18 May 2020, Jacek Caban wrote:

Signed-off-by: Jacek Caban <ja...@codeweavers.com>
---

Wine has relocation support in widl now, which conflicts with mingw-w64 relocation patch. Wine uses BIN_TO_INCLUDEDIR macro, which gets computed relative path. Wine has its own makedep, which takes care of computing that, but it would be a bit overkill to port that to mingw-w64. I used autoconf AX_COMPUTE_RELATIVE_PATH macro for that. This allows nice simplification of mingw-w64 - specific code.

AX_COMPUTE_RELATIVE_PATH doesn't seem to be available in the base autoconf distribution, so it'd be great to cache a copy of that in an m4 subdir, with the appropriate flags for including that dir.

Other than that, it looks good - I haven't tested the feature in detail but seems to work in general - and it looks like it's taking --with-widl-includedir into account, so that's good.

Same for other patch as well, looks good.


Thanks for the review. I added m4 dir and pushed.


Jacek



_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to