On 2020-06-09 10:41, Martin Storsjö wrote:
On Tue, 9 Jun 2020, Steve Lhomme wrote:
The functions in winstorecompat cannot be linked properly when
cryptoapi-l1-1-0
is linked at the same time.
Can you give a more technical explanation on this part? If symbols are
available in both, and winstorecompat is linked before cryptoapi-l1-1-0,
then it should always prefer the ones from winstorecompat, right? (At
least with how lld links things.)
Yes. I changed the order of my libs and that solved the double linking
issue. So we could do without this patch.
But in the end I think it's wrong to force users to link to keep
forbidden API's in libwindowsapp.a in general.
When used with mincore the only way to link these calls was through
winstorecompat so builds from be affected by this change.
^ this is missing a negation and the sentence isn't really parseable
around "builds from be"
s/from/won't/
index ebeeda2c..e3df36f3 100644
--- a/mingw-w64-crt/lib-common/api-ms-win-security-cryptoapi-l1-1-0.def
+++ b/mingw-w64-crt/lib-common/api-ms-win-security-cryptoapi-l1-1-0.def
@@ -2,8 +2,6 @@ LIBRARY api-ms-win-security-cryptoapi-l1-1-0
EXPORTS
-CryptAcquireContextA
-CryptAcquireContextW
CryptCreateHash
CryptDecrypt
I think it'd be good to keep them commented out, with a comment saying
they're intentionally removed - otherwise someone will probably readd it
soon...
Ah yes, I always forget.
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
