On 12.06.2020 14:38, Biswapriyo Nath wrote:
Question. The removal of `int i` declaration may be added with
wine-import.sh shell script by mistake. In wine, the int i variable is used
in for loop. IMHO, how about editing the wine/widl code?
* Now: for (i = 0; i < ARRAY_SIZE(incl_dirs); i++)
* Edited: for (int i = 0; i < ARRAY_SIZE(incl_dirs); i++)
The "Now" version seems to be coding style for wine. Yours opinion?
Variable declaration inside for statement is less portable. FWIW, my
plan is to change the code in Wine to make mingw-w64 redundant, so
whatever we do now will be temporary. My main problem is that I don't
really know how exactly people use it on Windows, so I have limited
trust for my testing. I did a change that was prerequisite for that and
planned to wait a bit to see if there are complains before patching Wine
with further changes.
If you'd like to look at that yourself, see init_argv0_dir. We'd need to
implement that for Windows case. Once we have that, we can #ifdef
__WINESRC__ Wine-specific part of main (the part that's currently
patched) and have another version that would be compatible with
mingw-w64 directory layout. Once we have that in Wine tree, relocation
patch will no longer be needed.
Jacek
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
