On 17.07.2020 21:41, Martin Storsjö wrote:
On Fri, 17 Jul 2020, Liu Hao wrote:
在 2020/7/17 22:28, Martin Storsjö 写道:
Sorry for the late reply, I started looking at this earlier but got
sidetracked back then.
In this case, _fseeki64 is a function in libmsvcrt-os.a while
fseeko64 is in libmingwex.a - does that cause problematic
dependencies, or did we already have such dependencies?
Other than that, the change looks good, I believe - any other issues
can probably only be found by taking the change into
use and seeing if something breaks somewhere.
Probably it is libmingwex that should depend on libmsvcrt-os, not the
other way around.
So here come two solutions:
0) Move `ftello.c` and `ftello64.c` into libmsvcrt-os.
Not sure if that's really ideal - as we need them somewhere for the
other CRTs (either in mingwex or in the other CRTs).
1) In addition to 0), rename the functions to `_fseeki()` and
`_fseeki64()`, then make `fseeko()` and `fseeko64()` in
libmingwex call the `_fseeki` variants instead.
I think that might be the better option, but I'd like to hear Jacek's
opinion before proceeding.
Sorry for joining the discussion late. How about implementing them
directly on top of msvcrt functions? Would something like:
return _telli64(_fileno(stream));
be enough for _ftelli64? Similarly:
return _lseeki64(_fileno(stream), offset, origin);
for fseeki64?
Thanks,
Jacek
_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
