On Wed, 31 Mar 2021, Liu Hao wrote:
在 2021/3/30 下午11:26, Martin Storsjö 写道:
On Tue, 30 Mar 2021, Liu Hao wrote:
The patch looks sensible to me (and good that you added a comment!). For 32
bit mode, I'd say default to whatever the headers default to.
However, please add the corresponding aliases to api-ms-win-crt*.def too;
the sum of them should be roughly equivalent to ucrtbase.
My decision was based on existent definitions in MSVCR*.DEFs. However MSVC
doesn't define `_USE_32BIT_TIME_T` by default, while mingw-w64 defines it in
<_mingw.h> if `__MINGW_USE_VC2005_COMPAT` is not defined, so for
i686-w64-mingw32, 32-bit `time_t` is still default.
My question is, are people who target UCRT still expecting a 32-bit `time_t`?
Hmm, if MSVC defaults to a 64 bit time_t in 32 bit mode these days, I
think we should too, for UCRT. (Technically I guess it's an ABI break, but
I'd be quite comfortable doing it, while I'd be less comfortable changing
any defaults for msvcrt.dll targets.)
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
