On Mon, 7 Jun 2021, Liu Hao wrote:

在 2021-06-05 14:16, Martin Storsjö 写道:
The second implementation, which was under the 'strtold' name, was
lacking (it didn't support e.g. strings like "0x125p-1"), while the
'__mingw_strtold' one seemed correct and complete.

Signed-off-by: Martin Storsjö <mar...@martin.st>
---
  mingw-w64-crt/Makefile.am         |    6 +-
  mingw-w64-crt/gdtoa/strtodnrp.c   |    4 +
  mingw-w64-crt/gdtoa/strtopx.c     |    4 +
  mingw-w64-crt/math/cephes_emath.c | 1283 -----------------------------
  mingw-w64-crt/math/cephes_emath.h |  719 ----------------
  mingw-w64-crt/misc/strtold.c      |  398 ---------
  6 files changed, 11 insertions(+), 2403 deletions(-)
  delete mode 100644 mingw-w64-crt/math/cephes_emath.c
  delete mode 100644 mingw-w64-crt/math/cephes_emath.h
  delete mode 100644 mingw-w64-crt/misc/strtold.c



All of these patches look good to me.

N.B. Actually I also used to wonder why we have to keep two `strtold()` implementations. The one by David M. Gay which you left intact is the de factor standard one, so I prefer it too.

Thanks, pushed both sets now.

// Martin

_______________________________________________
Mingw-w64-public mailing list
Mingw-w64-public@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public

Reply via email to