On Thu, 15 Jul 2021, LIU Hao wrote:
在 2021-07-13 17:21, Martin Storsjö 写道:
The mingw_pformat.c code converts all input floats to an 80 bit
float representation and analyzes that struct when printing the
float.
This was already fixed in
ceb4c4fd4b696e96bbe174ce4abc065d43e9ac87, but one case in
was missed. Factorize the conversion from 64 to 80 bit floats to
a function used to intialize the __pformat_fpreg_t struct.
Signed-off-by: Martin Storsjö <[email protected]>
---
mingw-w64-crt/stdio/mingw_pformat.c | 46 ++++++++++++++++-------------
1 file changed, 26 insertions(+), 20 deletions(-)
This patch looks good itself.
Thanks, pushed.
(Is it necessary to take this 64->80->string approach on ARM? It seems to me
an overkill.)
Yes, it's indeed overkill, but it feels like more effort to tweak all the
formatting code to work with two float representations, with more risk of
missing some case, or possibly ending up with more duplicated code. (Also
in general, there's less need for our own implementation on ARM with UCRT,
as the system one is generally modern and the long double stuff doesn't
mismatch like it does on x86.)
// Martin
_______________________________________________
Mingw-w64-public mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/mingw-w64-public
